qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Bolognani <abologna@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "Fabiano Rosas" <farosas@suse.de>,
	qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: Re: Re: [PATCH v2] tests/docker: Add sqlite3 module to openSUSE Leap container
Date: Fri, 19 Jan 2024 01:33:27 -0800	[thread overview]
Message-ID: <CABJz62NhxaGBEjC8kAPPzeWFsbcDSfhpmvP0K65CyuOdGhNqjQ@mail.gmail.com> (raw)
In-Reply-To: <98f6648c-59ce-42db-9afa-04f0a5521cba@tls.msk.ru>

On Fri, Jan 19, 2024 at 10:12:37AM +0300, Michael Tokarev wrote:
> 17.01.2024 19:42, Fabiano Rosas :
> > Avocado needs sqlite3:
>
> > --- a/tests/docker/dockerfiles/opensuse-leap.docker
> > +++ b/tests/docker/dockerfiles/opensuse-leap.docker
> > @@ -90,6 +90,7 @@ RUN zypper update -y && \
> >              pcre-devel-static \
> >              pipewire-devel \
> >              pkgconfig \
> > +           python311 \
> >              python311-base \
> >              python311-pip \
>
> Isn't python311 already pulls in python311-base?

Yes, but lcitool doesn't know that :)

The information that is provided to the tool is:

  * the python3 interpreter is in the python311-base package;
  * the venv module is also in the python311-base package;
  * the sqlite3 module is in the python311 package;

(via tests/lcitool/mappings.yml), as well as:

  * QEMU needs the python3 interpreter plus the venv and sqlite3
    packages to build;

(via tests/lcitool/projects/qemu.yml).

Based on that, it concludes that the python311-base and python311
package need to be installed.

Notice how the former shows up only once in the Dockerfile, despite
being mentioned twice in the list of dependencies for the project,
because some basic deduplication is applied.

Of course the extra line doesn't matter at all in practice:

  # zypper install python311
  The following 4 NEW packages are going to be installed:
    libexpat1 libpython3_11-1_0 python311 python311-base

  4 new packages to install.
  Overall download size: 12.8 MiB. Already cached: 0 B.
  After the operation, additional 50.4 MiB will be used.

  # zypper install python311 python311-base
  The following 4 NEW packages are going to be installed:
    libexpat1 libpython3_11-1_0 python311 python311-base

  4 new packages to install.
  Overall download size: 12.8 MiB. Already cached: 0 B.
  After the operation, additional 50.4 MiB will be used.

This is the main reason why we never really bothered trying to avoid
it.

Hope this helps!

-- 
Andrea Bolognani / Red Hat / Virtualization



      reply	other threads:[~2024-01-19  9:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 16:42 [PATCH v2] tests/docker: Add sqlite3 module to openSUSE Leap container Fabiano Rosas
2024-01-17 17:08 ` Philippe Mathieu-Daudé
2024-01-17 22:17 ` Alex Bennée
2024-01-19  7:11 ` Michael Tokarev
2024-01-19  7:12 ` Michael Tokarev
2024-01-19  9:33   ` Andrea Bolognani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABJz62NhxaGBEjC8kAPPzeWFsbcDSfhpmvP0K65CyuOdGhNqjQ@mail.gmail.com \
    --to=abologna@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=cfontana@suse.de \
    --cc=crosa@redhat.com \
    --cc=farosas@suse.de \
    --cc=mjt@tls.msk.ru \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).