From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C95ACC05027 for ; Wed, 8 Feb 2023 16:49:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPndB-00070u-I3; Wed, 08 Feb 2023 11:49:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPnd3-00070V-Ti for qemu-devel@nongnu.org; Wed, 08 Feb 2023 11:49:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPnd0-0001xR-W4 for qemu-devel@nongnu.org; Wed, 08 Feb 2023 11:49:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675874941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1rBO6BPxX2JsKKWVKM4Id2mvZ/jNawONjRxMddbGT9k=; b=Rp9w0X+gHColNrxjfAyDYpULnQZGI+qBzj419lVbNEUfWY+deG//PHq2rlRAigBFzk+GlI i1CBzKPsahKga5l1F6SU+slXRg8KRIPvcjAg5gUi0mRbNu+Q9a1WR53VJNai/IAHBW73+l h6q65qBIbgzfYQjXKbyvGWReLNXL6VQ= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-249-Gl-Le4jrMdKAROxREB1kpg-1; Wed, 08 Feb 2023 11:49:00 -0500 X-MC-Unique: Gl-Le4jrMdKAROxREB1kpg-1 Received: by mail-pj1-f70.google.com with SMTP id s20-20020a17090b071400b00230ecf76407so1287328pjz.3 for ; Wed, 08 Feb 2023 08:49:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:in-reply-to :mime-version:references:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1rBO6BPxX2JsKKWVKM4Id2mvZ/jNawONjRxMddbGT9k=; b=DWrlzXDai17GMvnc/WXsygE2PHMoqyT6PekXWhXnyBzit/5fdR9xZjxAAJQPT7WUm9 7VFJq0dp2YcIoFbLtAI9sN7e0px8GqjT/H5yDtrTIRjr8//KmbCLzY+JTYeW5NSEavWb L66VQyrYd0WgyTxWlPRyEoDpeMBEgQh1+68Qd4a54K/VuZXm1OpVF09ADGJojNUieMXE JwbQscb5dcnsQkiVGhrTscW81e6RChNLWDvqxTZ8oDWEZDERXILyVlWURw6UiAJdsI7d ubL9ISwa6T+3o0ryHIIOqSqVXtD1pl8GgTh2xssRHk0B/B/i15SD6jA2yTz6MziS+Tqd iJEw== X-Gm-Message-State: AO0yUKU5O/ja23ltqT2Fq2+9xE/zFKbcKYch8DtrnS0cVm7BZ+t0zGGK EvrLTFHRPTmWwrbptOyRspMimMNMYeu508DI8NSdbAN/OxFhSnxKtGgefuv/65HPXRWYh76IbQG lJAXIttnEA+3St+Yz+KQbgP1e+pKSeoA= X-Received: by 2002:a62:1c08:0:b0:590:762f:58bc with SMTP id c8-20020a621c08000000b00590762f58bcmr1755517pfc.50.1675874939208; Wed, 08 Feb 2023 08:48:59 -0800 (PST) X-Google-Smtp-Source: AK7set9xRAGJcNCX+DiKV/md7TdgznjA3jdrc0kaqctbi7+Ms62lfu2n/YwfLrNsEeASkGIbEnrQVoGKlaNr6lqA2p8= X-Received: by 2002:a62:1c08:0:b0:590:762f:58bc with SMTP id c8-20020a621c08000000b00590762f58bcmr1755504pfc.50.1675874938886; Wed, 08 Feb 2023 08:48:58 -0800 (PST) Received: from 744723338238 named unknown by gmailapi.google.com with HTTPREST; Wed, 8 Feb 2023 08:48:58 -0800 From: Andrea Bolognani References: <20230202045223.2594627-1-sunilvl@ventanamicro.com> <20230202045223.2594627-3-sunilvl@ventanamicro.com> <20230207102353.hpg2gxh22urjbebu@orel> <9c05b850-ae25-12aa-c6d0-b7a813a5ee03@redhat.com> <20230207192031.pu5uy2yppv3htjw5@orel> MIME-Version: 1.0 In-Reply-To: <20230207192031.pu5uy2yppv3htjw5@orel> Date: Wed, 8 Feb 2023 08:48:58 -0800 Message-ID: Subject: Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI To: Andrew Jones Cc: Thomas Huth , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Sunil V L , Palmer Dabbelt , Alistair Francis , Bin Meng , qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Anup Patel , Atish Kumar Patra , Ani Sinha , "Michael S. Tsirkin" , Markus Armbruster , Igor Mammedov , Gerd Hoffmann , Bernhard Beschow Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=abologna@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Feb 07, 2023 at 08:20:31PM +0100, Andrew Jones wrote: > On Tue, Feb 07, 2023 at 06:38:15AM -0800, Andrea Bolognani wrote: > > Well, it looks like -no-acpi will come for free after all, thanks to > > the code you pasted above, as long as the machine property follows > > the convention established by x86, arm and (I just noticed this one) > > loongarch. > > Not quite, because we also have > > $ grep -A1 '"no-acpi"' qemu-options.hx > DEF("no-acpi", 0, QEMU_OPTION_no_acpi, > "-no-acpi disable ACPI\n", QEMU_ARCH_I386 | QEMU_ARCH_A= RM) > > So that means neither riscv nor loongarch get -no-acpi just by adding > the "acpi" machine property. > > If the plan is to deprecate -no-acpi, then riscv can be like loongarch > and only have the "acpi" property from the start. Makes sense. For the libvirt integration, do I understand correctly that the machine property was added by commit commit 17e89077b7e3bc1d96540e21ddc7451c3e077049 Author: Gerd Hoffmann Date: Fri Mar 20 11:01:36 2020 +0100 acpi: add acpi=3DOnOffAuto machine property to x86 and arm virt Remove the global acpi_enabled bool and replace it with an acpi OnOffAuto machine property. qemu throws an error now if you use -no-acpi while the machine type you are using doesn't support acpi in the first place. Signed-off-by: Gerd Hoffmann Message-Id: <20200320100136.11717-1-kraxel@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin included in QEMU 5.0? libvirt still officially supports QEMU 4.2, so we'll have to make the use of the machine property conditional. --=20 Andrea Bolognani / Red Hat / Virtualization