Issue with vl.c: move -m parsing after memory backends has been processed. Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047

[Howard Spoelstra <hsp.cat7@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

Hi all,

Commit a1b18df9a4848fc8a906e40c275063bfe9ca2047 on the ppc-for-50 branch
makes qemu-system-ppc running Mac OS 9 extremely slow. I bisected to the
result below.

Command line used:
./qemu-system-ppc -L pc-bios -M mac99,via=pmu -m 512 -boot c \
-hda 9.2.img \
-serial stdio -sdl

Best,
Howard

a1b18df9a4848fc8a906e40c275063bfe9ca2047 is the first bad commit
commit a1b18df9a4848fc8a906e40c275063bfe9ca2047
Author: Igor Mammedov <imammedo@redhat.com>
Date:   Wed Feb 19 11:08:40 2020 -0500

    vl.c: move -m parsing after memory backends has been processed

    It will be possible for main RAM to come from memory-backend
    and we should check that size specified in -m matches the size
    of the backend and [MachineState::]ram_size also matches
    backend's size.

    However -m parsing (set_memory_options()) happens before backends
    are intialized (object_create_delayed()) which complicates it.
    Consolidate set_memory_options() and assigning parsed results to
    current_machine after backends are initialized, so it would be
    possible access the initialized backend instance to compare
    sizes.

    This patch only consolidates scattered places touching ram_size
    within vl.c. And follow up patch will integrate backend handling
    to set_memory_options().

    Signed-off-by: Igor Mammedov <imammedo@redhat.com>
    Message-Id: <20200219160953.13771-7-imammedo@redhat.com>

 vl.c | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

[-- Attachment #2: Type: text/html, Size: 1978 bytes --]