From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thibaut.collet@6wind.com>) id 1a1cFr-0004E2-59
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 10:45:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thibaut.collet@6wind.com>) id 1a1cFq-0005G0-0c
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 10:45:11 -0500
Received: from mail-qg0-x22f.google.com ([2607:f8b0:400d:c04::22f]:35047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thibaut.collet@6wind.com>) id 1a1cFp-0005Fs-Ra
	for qemu-devel@nongnu.org; Wed, 25 Nov 2015 10:45:09 -0500
Received: by qgec40 with SMTP id c40so34493443qge.2
	for <qemu-devel@nongnu.org>; Wed, 25 Nov 2015 07:45:09 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1448455324-31122-1-git-send-email-mst@redhat.com>
References: <1448455324-31122-1-git-send-email-mst@redhat.com>
Date: Wed, 25 Nov 2015 16:45:09 +0100
Message-ID: <CABUUfwMom3Hrd=LHC19diyg7HTBsbieR7UMzptby+Ox0Aqzwvg@mail.gmail.com>
From: Thibaut Collet <thibaut.collet@6wind.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at
	start/stop"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>, qemu-devel <qemu-devel@nongnu.org>

On Wed, Nov 25, 2015 at 1:42 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76.
>
> In case of live migration several queues can be enabled and not only the
> first one. So informing backend that only the first queue is enabled is
> wrong.
>
> Reported-by: Thibaut Collet <thibaut.collet@6wind.com>
> Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/virtio/vhost.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 1794f0d..de29968 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
>          }
>      }
>
> -    if (hdev->vhost_ops->vhost_set_vring_enable) {
> -        /* only enable first vq pair by default */
> -        hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0);
> -    }
> -
>      return 0;
>  fail_log:
>      vhost_log_put(hdev, false);
> @@ -1261,10 +1256,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev)
>                               hdev->vq_index + i);
>      }
>
> -    if (hdev->vhost_ops->vhost_set_vring_enable) {
> -        hdev->vhost_ops->vhost_set_vring_enable(hdev, 0);
> -    }
> -
>      vhost_log_put(hdev, true);
>      hdev->started = false;
>      hdev->log = NULL;
> --

Ack

> MST