From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/intc/armv7m_nvic: Fix typo in comment
Date: Fri, 25 Feb 2022 22:44:27 +1100 [thread overview]
Message-ID: <CABbZYZJhiA6GoTDjNX6W1tAX3c-1TCAQuX2SczGyZXjrO3grmA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8zKcZ7=gRmKX0fygpdmYfEf-HEodfH+SXwS_fT+rt2Ag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
Ah, indeed.
Sorry for having bothered you.
On Thu, 24 Feb 2022, 23:46 Peter Maydell, <peter.maydell@linaro.org> wrote:
> On Thu, 24 Feb 2022 at 12:22, Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
> wrote:
> >
> > Signed-off-by: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
> > ---
> > hw/intc/armv7m_nvic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> > index 13df002ce4..a08a0fdc50 100644
> > --- a/hw/intc/armv7m_nvic.c
> > +++ b/hw/intc/armv7m_nvic.c
> > @@ -97,7 +97,7 @@ static int nvic_pending_prio(NVICState *s)
> > * this is only different in the obscure corner case where guest
> > * code has manually deactivated an exception and is about
> > * to fail an exception-return integrity check. The definition
> > - * above is the one from the v8M ARM ARM and is also in line
> > + * above is the one from the v8M ARM and is also in line
> > * with the behaviour documented for the Cortex-M3.
> > */
>
> This is not a typo. The "ARM ARM" (or "Arm ARM" these days if
> you want to follow the official corporate name capitalization)
> is the standard abbreviated way to refer to the
> Arm Architecture Reference Manual. "git grep -i 'arm arm'"
> finds over 50 uses of it in various comments.
>
> thanks
> -- PMM
>
[-- Attachment #2: Type: text/html, Size: 2057 bytes --]
prev parent reply other threads:[~2022-02-25 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 12:21 [PATCH] hw/intc/armv7m_nvic: Fix typo in comment Evgeny Ermakov
2022-02-24 12:46 ` Peter Maydell
2022-02-25 11:44 ` Evgeny Ermakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABbZYZJhiA6GoTDjNX6W1tAX3c-1TCAQuX2SczGyZXjrO3grmA@mail.gmail.com \
--to=evgeny.v.ermakov@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).