* [Qemu-devel] [PATCH 0/1] snip my name and email @ 2019-02-21 15:53 David Kiarie 2019-02-21 15:53 ` [Qemu-devel] [PATCH 1/1] hw/i386: " David Kiarie ` (2 more replies) 0 siblings, 3 replies; 14+ messages in thread From: David Kiarie @ 2019-02-21 15:53 UTC (permalink / raw) To: qemu-devel; +Cc: jan.kiszka, peterx, mst, alexaltea123, David Kiarie the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs. i have therefore choosen to snip it. David Kiarie (1): hw/i386: snip my name and email hw/i386/amd_iommu.c | 1 - hw/i386/amd_iommu.h | 1 - 2 files changed, 2 deletions(-) -- 2.20.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH 1/1] hw/i386: snip my name and email 2019-02-21 15:53 [Qemu-devel] [PATCH 0/1] snip my name and email David Kiarie @ 2019-02-21 15:53 ` David Kiarie 2019-02-21 16:19 ` Daniel P. Berrangé 2019-02-21 16:05 ` [Qemu-devel] [PATCH 0/1] " Eric Blake 2019-02-27 18:02 ` no-reply 2 siblings, 1 reply; 14+ messages in thread From: David Kiarie @ 2019-02-21 15:53 UTC (permalink / raw) To: qemu-devel; +Cc: jan.kiszka, peterx, mst, alexaltea123, David Kiarie --- hw/i386/amd_iommu.c | 1 - hw/i386/amd_iommu.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 8ad707a..e4f3e9c 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -2,7 +2,6 @@ * QEMU emulation of AMD IOMMU (AMD-Vi) * * Copyright (C) 2011 Eduard - Gabriel Munteanu - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h index c52886f..7d577d0 100644 --- a/hw/i386/amd_iommu.h +++ b/hw/i386/amd_iommu.h @@ -2,7 +2,6 @@ * QEMU emulation of an AMD IOMMU (AMD-Vi) * * Copyright (C) 2011 Eduard - Gabriel Munteanu - * Copyright (C) 2015 David Kiarie, <davidkiarie4@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by -- 2.20.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] hw/i386: snip my name and email 2019-02-21 15:53 ` [Qemu-devel] [PATCH 1/1] hw/i386: " David Kiarie @ 2019-02-21 16:19 ` Daniel P. Berrangé 2019-02-21 16:54 ` David Kiarie 0 siblings, 1 reply; 14+ messages in thread From: Daniel P. Berrangé @ 2019-02-21 16:19 UTC (permalink / raw) To: David Kiarie; +Cc: qemu-devel, alexaltea123, jan.kiszka, peterx, mst On Thu, Feb 21, 2019 at 06:53:59PM +0300, David Kiarie wrote: Note, patches to QEMU are required to have a signed-off-by line in the commit message with name + email address to indicate your contribution follows the submission rules https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] hw/i386: snip my name and email 2019-02-21 16:19 ` Daniel P. Berrangé @ 2019-02-21 16:54 ` David Kiarie 0 siblings, 0 replies; 14+ messages in thread From: David Kiarie @ 2019-02-21 16:54 UTC (permalink / raw) To: Daniel P. Berrangé Cc: QEMU Developers, Alexandro Sánchez Bach, Jan Kiszka, Peter Xu, Michael S. Tsirkin On Thu, Feb 21, 2019 at 7:19 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > On Thu, Feb 21, 2019 at 06:53:59PM +0300, David Kiarie wrote: > > Note, patches to QEMU are required to have a signed-off-by line in the > commit message with name + email address to indicate your contribution > follows the submission rules > > > https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line > > > noted. thanks. > Regards, > Daniel > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 15:53 [Qemu-devel] [PATCH 0/1] snip my name and email David Kiarie 2019-02-21 15:53 ` [Qemu-devel] [PATCH 1/1] hw/i386: " David Kiarie @ 2019-02-21 16:05 ` Eric Blake 2019-02-21 16:09 ` Jan Kiszka 2019-02-27 18:02 ` no-reply 2 siblings, 1 reply; 14+ messages in thread From: Eric Blake @ 2019-02-21 16:05 UTC (permalink / raw) To: David Kiarie, qemu-devel; +Cc: alexaltea123, jan.kiszka, peterx, mst On 2/21/19 9:53 AM, David Kiarie wrote: > the occurrence of my name and email on the files below may have led to > some confusion in the reporting of a few recent bugs. > > i have therefore choosen to snip it. Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 16:05 ` [Qemu-devel] [PATCH 0/1] " Eric Blake @ 2019-02-21 16:09 ` Jan Kiszka 2019-02-21 16:48 ` Markus Armbruster 2019-02-21 20:47 ` David Kiarie 0 siblings, 2 replies; 14+ messages in thread From: Jan Kiszka @ 2019-02-21 16:09 UTC (permalink / raw) To: Eric Blake, David Kiarie, qemu-devel; +Cc: alexaltea123, peterx, mst On 21.02.19 17:05, Eric Blake wrote: > On 2/21/19 9:53 AM, David Kiarie wrote: >> the occurrence of my name and email on the files below may have led to >> some confusion in the reporting of a few recent bugs. >> >> i have therefore choosen to snip it. > > Dropping an email from the copyright line makes sense; dropping the > Copyright declaration altogether is a bit odd (the GPL works only in > tandem with a copyright assertion) - but as you are the author of the > line and copyright holder of your contributions, I am not in a position > to say you are wrong in removing it, only that it looks odd. > Yeah, indeed. David, also note that you probably have been addressed because scripts/get_maintainer.pl will look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there. There should be some opt-out statement from that, but I don't recall how. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 16:09 ` Jan Kiszka @ 2019-02-21 16:48 ` Markus Armbruster 2019-02-21 16:52 ` Jan Kiszka 2019-02-21 20:47 ` David Kiarie 1 sibling, 1 reply; 14+ messages in thread From: Markus Armbruster @ 2019-02-21 16:48 UTC (permalink / raw) To: Jan Kiszka Cc: Eric Blake, David Kiarie, qemu-devel, alexaltea123, peterx, mst Jan Kiszka <jan.kiszka@siemens.com> writes: > On 21.02.19 17:05, Eric Blake wrote: >> On 2/21/19 9:53 AM, David Kiarie wrote: >>> the occurrence of my name and email on the files below may have led to >>> some confusion in the reporting of a few recent bugs. >>> >>> i have therefore choosen to snip it. >> >> Dropping an email from the copyright line makes sense; dropping the >> Copyright declaration altogether is a bit odd (the GPL works only in >> tandem with a copyright assertion) - but as you are the author of the >> line and copyright holder of your contributions, I am not in a position >> to say you are wrong in removing it, only that it looks odd. >> > > Yeah, indeed. > > David, also note that you probably have been addressed because > scripts/get_maintainer.pl will look into the git history of files that > some patch addresses and pick up significant and/or recent > contributors from there. MAINTAINERS covers these files, so the most common use of get_maintainer.pl won't list anyone not listed there: $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) Richard Henderson <rth@twiddle.net> (maintainer:X86) Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC) Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) qemu-devel@nongnu.org (open list:All patches CC here) David's contributions have aged out of --git: $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%) Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%) Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%) "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%) Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%) qemu-devel@nongnu.org (open list:All patches CC here) However, --git-blame still lists him: $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%) Richard Henderson <rth@twiddle.net> (maintainer:X86) Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%) "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%) Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%) Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%) David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%) Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%) Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%) qemu-devel@nongnu.org (open list:All patches CC here) --help admonishes: Using "--git-blame" is slow and may add old committers and authors that are no longer active maintainers to the output. > There should be some opt-out statement from > that, but I don't recall how. I don't think get_maintainer.pl supports a blacklist of people who don't want to be pestered anymore. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 16:48 ` Markus Armbruster @ 2019-02-21 16:52 ` Jan Kiszka 2019-02-21 16:57 ` David Kiarie 2019-02-21 17:13 ` Markus Armbruster 0 siblings, 2 replies; 14+ messages in thread From: Jan Kiszka @ 2019-02-21 16:52 UTC (permalink / raw) To: Markus Armbruster Cc: Eric Blake, David Kiarie, qemu-devel, alexaltea123, peterx, mst On 21.02.19 17:48, Markus Armbruster wrote: > Jan Kiszka <jan.kiszka@siemens.com> writes: > >> On 21.02.19 17:05, Eric Blake wrote: >>> On 2/21/19 9:53 AM, David Kiarie wrote: >>>> the occurrence of my name and email on the files below may have led to >>>> some confusion in the reporting of a few recent bugs. >>>> >>>> i have therefore choosen to snip it. >>> >>> Dropping an email from the copyright line makes sense; dropping the >>> Copyright declaration altogether is a bit odd (the GPL works only in >>> tandem with a copyright assertion) - but as you are the author of the >>> line and copyright holder of your contributions, I am not in a position >>> to say you are wrong in removing it, only that it looks odd. >>> >> >> Yeah, indeed. >> >> David, also note that you probably have been addressed because >> scripts/get_maintainer.pl will look into the git history of files that >> some patch addresses and pick up significant and/or recent >> contributors from there. > > MAINTAINERS covers these files, so the most common use of > get_maintainer.pl won't list anyone not listed there: > > $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] > Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) > Richard Henderson <rth@twiddle.net> (maintainer:X86) > Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) > "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC) > Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) > qemu-devel@nongnu.org (open list:All patches CC here) > > David's contributions have aged out of --git: > > $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git > "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) > Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) > Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) > Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%) > Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) > Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%) > Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%) > "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%) > Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%) > qemu-devel@nongnu.org (open list:All patches CC here) > > However, --git-blame still lists him: > > $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame > Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%) > Richard Henderson <rth@twiddle.net> (maintainer:X86) > Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%) > "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%) > Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) > David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%) > Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) > Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%) > David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%) > Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%) > Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%) > qemu-devel@nongnu.org (open list:All patches CC here) > > --help admonishes: > > Using "--git-blame" is slow and may add old committers and authors > that are no longer active maintainers to the output. > >> There should be some opt-out statement from >> that, but I don't recall how. > > I don't think get_maintainer.pl supports a blacklist of people who don't > want to be pestered anymore. > # cat linux/.get_maintainer.ignore Christoph Hellwig <hch@lst.de> That's why I remembered it vaguely. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 16:52 ` Jan Kiszka @ 2019-02-21 16:57 ` David Kiarie 2019-02-21 17:13 ` Markus Armbruster 1 sibling, 0 replies; 14+ messages in thread From: David Kiarie @ 2019-02-21 16:57 UTC (permalink / raw) To: Jan Kiszka Cc: Markus Armbruster, Eric Blake, QEMU Developers, Alexandro Sánchez Bach, Peter Xu, Michael S. Tsirkin i will just drop the email. thanks. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 16:52 ` Jan Kiszka 2019-02-21 16:57 ` David Kiarie @ 2019-02-21 17:13 ` Markus Armbruster 2019-02-21 17:35 ` Philippe Mathieu-Daudé 1 sibling, 1 reply; 14+ messages in thread From: Markus Armbruster @ 2019-02-21 17:13 UTC (permalink / raw) To: Jan Kiszka; +Cc: mst, qemu-devel, peterx, alexaltea123, David Kiarie Jan Kiszka <jan.kiszka@siemens.com> writes: > On 21.02.19 17:48, Markus Armbruster wrote: >> Jan Kiszka <jan.kiszka@siemens.com> writes: >> >>> On 21.02.19 17:05, Eric Blake wrote: >>>> On 2/21/19 9:53 AM, David Kiarie wrote: >>>>> the occurrence of my name and email on the files below may have led to >>>>> some confusion in the reporting of a few recent bugs. >>>>> >>>>> i have therefore choosen to snip it. >>>> >>>> Dropping an email from the copyright line makes sense; dropping the >>>> Copyright declaration altogether is a bit odd (the GPL works only in >>>> tandem with a copyright assertion) - but as you are the author of the >>>> line and copyright holder of your contributions, I am not in a position >>>> to say you are wrong in removing it, only that it looks odd. >>>> >>> >>> Yeah, indeed. >>> >>> David, also note that you probably have been addressed because >>> scripts/get_maintainer.pl will look into the git history of files that >>> some patch addresses and pick up significant and/or recent >>> contributors from there. >> >> MAINTAINERS covers these files, so the most common use of >> get_maintainer.pl won't list anyone not listed there: >> >> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] >> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) >> Richard Henderson <rth@twiddle.net> (maintainer:X86) >> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) >> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC) >> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >> qemu-devel@nongnu.org (open list:All patches CC here) >> >> David's contributions have aged out of --git: >> >> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git >> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) >> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) >> Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%) >> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) >> Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%) >> Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%) >> "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%) >> Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%) >> qemu-devel@nongnu.org (open list:All patches CC here) >> >> However, --git-blame still lists him: >> >> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame >> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%) >> Richard Henderson <rth@twiddle.net> (maintainer:X86) >> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%) >> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%) >> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >> David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%) >> Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) >> Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%) >> David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%) >> Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%) >> Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%) >> qemu-devel@nongnu.org (open list:All patches CC here) >> >> --help admonishes: >> >> Using "--git-blame" is slow and may add old committers and authors >> that are no longer active maintainers to the output. >> >>> There should be some opt-out statement from >>> that, but I don't recall how. >> >> I don't think get_maintainer.pl supports a blacklist of people who don't >> want to be pestered anymore. >> > > # cat linux/.get_maintainer.ignore > Christoph Hellwig <hch@lst.de> > > That's why I remembered it vaguely. Ah! commit 435de0782b658c993350049e853ea9a8795df4e2 Author: Joe Perches <joe@perches.com> Date: Thu Jun 25 15:01:50 2015 -0700 get_maintainer.pl: add .get_maintainer.ignore file capability Some people prefer not to be cc'd on patches. Add an ability to have a file (.get_maintainer.ignore) with names and email addresses that are excluded from being listed except when specifically listed as a maintainer in a section. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Can we resync with the kernel's script to get this feature? Or should we cherry-pick it? ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 17:13 ` Markus Armbruster @ 2019-02-21 17:35 ` Philippe Mathieu-Daudé 2019-02-21 17:42 ` David Kiarie 0 siblings, 1 reply; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2019-02-21 17:35 UTC (permalink / raw) To: Markus Armbruster, Jan Kiszka Cc: alexaltea123, David Kiarie, qemu-devel, peterx, mst On 2/21/19 6:13 PM, Markus Armbruster wrote: > Jan Kiszka <jan.kiszka@siemens.com> writes: > >> On 21.02.19 17:48, Markus Armbruster wrote: >>> Jan Kiszka <jan.kiszka@siemens.com> writes: >>> >>>> On 21.02.19 17:05, Eric Blake wrote: >>>>> On 2/21/19 9:53 AM, David Kiarie wrote: >>>>>> the occurrence of my name and email on the files below may have led to >>>>>> some confusion in the reporting of a few recent bugs. >>>>>> >>>>>> i have therefore choosen to snip it. >>>>> >>>>> Dropping an email from the copyright line makes sense; dropping the >>>>> Copyright declaration altogether is a bit odd (the GPL works only in >>>>> tandem with a copyright assertion) - but as you are the author of the >>>>> line and copyright holder of your contributions, I am not in a position >>>>> to say you are wrong in removing it, only that it looks odd. >>>>> >>>> >>>> Yeah, indeed. >>>> >>>> David, also note that you probably have been addressed because >>>> scripts/get_maintainer.pl will look into the git history of files that >>>> some patch addresses and pick up significant and/or recent >>>> contributors from there. >>> >>> MAINTAINERS covers these files, so the most common use of >>> get_maintainer.pl won't list anyone not listed there: >>> >>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] >>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) >>> Richard Henderson <rth@twiddle.net> (maintainer:X86) >>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) >>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC) >>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> David's contributions have aged out of --git: >>> >>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git >>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) >>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86) >>> Richard Henderson <rth@twiddle.net> (maintainer:X86,commit_signer:1/7=14%) >>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86) >>> Peter Xu <peterx@redhat.com> (commit_signer:6/7=86%,commit_signer:4/5=80%) >>> Brijesh Singh <brijesh.singh@amd.com> (commit_signer:5/7=71%,commit_signer:4/5=80%) >>> "Alex Bennée" <alex.bennee@linaro.org> (commit_signer:1/7=14%) >>> Jan Kiszka <jan.kiszka@siemens.com> (commit_signer:1/5=20%) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> However, --git-blame still lists him: >>> >>> $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame >>> Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86,commits:7/24=29%) >>> Richard Henderson <rth@twiddle.net> (maintainer:X86) >>> Eduardo Habkost <ehabkost@redhat.com> (maintainer:X86,commits:7/24=29%) >>> "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC,commits:26/24=100%,commits:14/8=100%) >>> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC) >>> David Kiarie <davidkiarie4@gmail.com> (authored lines:1176/1645=71%,authored lines:274/373=73%) >>> Brijesh Singh <brijesh.singh@amd.com> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) >>> Peter Xu <peterx@redhat.com> (commits:10/24=42%,commits:4/8=50%) >>> David Gibson <david@gibson.dropbear.id.au> (commits:7/24=29%) >>> Jan Kiszka <jan.kiszka@siemens.com> (commits:1/8=12%) >>> Prasad J Pandit <pjp@fedoraproject.org> (commits:1/8=12%) >>> qemu-devel@nongnu.org (open list:All patches CC here) >>> >>> --help admonishes: >>> >>> Using "--git-blame" is slow and may add old committers and authors >>> that are no longer active maintainers to the output. >>> >>>> There should be some opt-out statement from >>>> that, but I don't recall how. >>> >>> I don't think get_maintainer.pl supports a blacklist of people who don't >>> want to be pestered anymore. >>> >> >> # cat linux/.get_maintainer.ignore >> Christoph Hellwig <hch@lst.de> >> >> That's why I remembered it vaguely. > > Ah! > > commit 435de0782b658c993350049e853ea9a8795df4e2 > Author: Joe Perches <joe@perches.com> > Date: Thu Jun 25 15:01:50 2015 -0700 > > get_maintainer.pl: add .get_maintainer.ignore file capability > > Some people prefer not to be cc'd on patches. Add an ability to have a > file (.get_maintainer.ignore) with names and email addresses that are > excluded from being listed except when specifically listed as a maintainer > in a section. > > Signed-off-by: Joe Perches <joe@perches.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> > > Can we resync with the kernel's script to get this feature? Or should > we cherry-pick it? I think we are out-of-sync and only cherry-picking. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 17:35 ` Philippe Mathieu-Daudé @ 2019-02-21 17:42 ` David Kiarie 0 siblings, 0 replies; 14+ messages in thread From: David Kiarie @ 2019-02-21 17:42 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Markus Armbruster, Jan Kiszka, Alexandro Sánchez Bach, QEMU Developers, Peter Xu, Michael S. Tsirkin On Thu, Feb 21, 2019 at 8:35 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > On 2/21/19 6:13 PM, Markus Armbruster wrote: > > > > > Can we resync with the kernel's script to get this feature? Or should > > we cherry-pick it? > > I think we are out-of-sync and only cherry-picking. > you can do this if you so wish but i am personally okay with the follow up patch i sent. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 16:09 ` Jan Kiszka 2019-02-21 16:48 ` Markus Armbruster @ 2019-02-21 20:47 ` David Kiarie 1 sibling, 0 replies; 14+ messages in thread From: David Kiarie @ 2019-02-21 20:47 UTC (permalink / raw) To: Jan Kiszka; +Cc: Eric Blake, QEMU Developers On Thu, Feb 21, 2019 at 7:09 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 21.02.19 17:05, Eric Blake wrote: > > On 2/21/19 9:53 AM, David Kiarie wrote: > >> the occurrence of my name and email on the files below may have led to > >> some confusion in the reporting of a few recent bugs. > >> > >> i have therefore choosen to snip it. > > > > Dropping an email from the copyright line makes sense; dropping the > > Copyright declaration altogether is a bit odd (the GPL works only in > > tandem with a copyright assertion) - but as you are the author of the > > line and copyright holder of your contributions, I am not in a position > > to say you are wrong in removing it, only that it looks odd. > > > > Yeah, indeed. > > David, also note that you probably have been addressed because > scripts/get_maintainer.pl will look into the git history of files that > some > patch addresses and pick up significant and/or recent contributors from > there. > There should be some opt-out statement from that, but I don't recall how. > > Jan, Eblake, i respect your opinion but i still think my original patch would have been best fit for the simple me. > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/1] snip my name and email 2019-02-21 15:53 [Qemu-devel] [PATCH 0/1] snip my name and email David Kiarie 2019-02-21 15:53 ` [Qemu-devel] [PATCH 1/1] hw/i386: " David Kiarie 2019-02-21 16:05 ` [Qemu-devel] [PATCH 0/1] " Eric Blake @ 2019-02-27 18:02 ` no-reply 2 siblings, 0 replies; 14+ messages in thread From: no-reply @ 2019-02-27 18:02 UTC (permalink / raw) To: davidkiarie4; +Cc: fam, qemu-devel, alexaltea123, jan.kiszka, peterx, mst Patchew URL: https://patchew.org/QEMU/20190221155359.8247-1-davidkiarie4@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190221155359.8247-1-davidkiarie4@gmail.com Subject: [Qemu-devel] [PATCH 0/1] snip my name and email Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3840647010 hw/i386: snip my name and email === OUTPUT BEGIN === ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 14 lines checked Commit 384064701074 (hw/i386: snip my name and email) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190221155359.8247-1-davidkiarie4@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-02-27 18:04 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-02-21 15:53 [Qemu-devel] [PATCH 0/1] snip my name and email David Kiarie 2019-02-21 15:53 ` [Qemu-devel] [PATCH 1/1] hw/i386: " David Kiarie 2019-02-21 16:19 ` Daniel P. Berrangé 2019-02-21 16:54 ` David Kiarie 2019-02-21 16:05 ` [Qemu-devel] [PATCH 0/1] " Eric Blake 2019-02-21 16:09 ` Jan Kiszka 2019-02-21 16:48 ` Markus Armbruster 2019-02-21 16:52 ` Jan Kiszka 2019-02-21 16:57 ` David Kiarie 2019-02-21 17:13 ` Markus Armbruster 2019-02-21 17:35 ` Philippe Mathieu-Daudé 2019-02-21 17:42 ` David Kiarie 2019-02-21 20:47 ` David Kiarie 2019-02-27 18:02 ` no-reply
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).