From: Ladi Prosek <lprosek@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Fernando Casas Schössow" <casasfernando@hotmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
arei.gonglei@huawei.com, aneesh.kumar@linux.vnet.ibm.com,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/8] virtio: introduce virtqueue_error
Date: Thu, 13 Jul 2017 17:02:08 +0200 [thread overview]
Message-ID: <CABdb7367eVJNd8hWqVpF3RN58g7xchCyPLP=aaTy7jKXd8ws+A@mail.gmail.com> (raw)
In-Reply-To: <20170713164210.45b2f3fc@gondolin>
On Thu, Jul 13, 2017 at 4:42 PM, Cornelia Huck <cohuck@redhat.com> wrote:
> On Thu, 13 Jul 2017 13:02:32 +0200
> Ladi Prosek <lprosek@redhat.com> wrote:
>
>> Most virtio error output pertains to a specific virtqueue so it makes
>> sense to include the queue index in error messages. This commit makes
>> all error output in virtio.c use the newly introduced virtqueue_error.
>
> Split out the change introducing virtqueue_error(), as this patch is
> quite large?
Will do, thanks!
>>
>> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Ladi Prosek <lprosek@redhat.com>
>> ---
>> hw/virtio/virtio.c | 98 ++++++++++++++++++++++++++++------------------
>> include/hw/virtio/virtio.h | 1 +
>> 2 files changed, 60 insertions(+), 39 deletions(-)
>
> I like the change. Feel free to add
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-07-13 15:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 11:02 [Qemu-devel] [PATCH v2 0/8] virtio: enhance virtio_error messages Ladi Prosek
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf Ladi Prosek
2017-07-13 13:32 ` Stefan Hajnoczi
2017-07-13 13:48 ` Ladi Prosek
2017-07-14 10:25 ` Stefan Hajnoczi
2017-07-15 5:50 ` Markus Armbruster
2017-07-17 6:43 ` Ladi Prosek
2017-07-14 10:41 ` Daniel P. Berrange
2017-07-17 6:54 ` Ladi Prosek
2017-07-17 8:58 ` Daniel P. Berrange
2017-07-17 9:30 ` Ladi Prosek
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 2/8] virtio: enhance virtio_error messages Ladi Prosek
2017-07-13 13:40 ` Stefan Hajnoczi
2017-07-13 13:58 ` Ladi Prosek
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 3/8] virtio: introduce virtqueue_error Ladi Prosek
2017-07-13 14:42 ` Cornelia Huck
2017-07-13 15:02 ` Ladi Prosek [this message]
2017-07-14 10:28 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 4/8] virtio-9p: use virtqueue_error for errors with queue context Ladi Prosek
2017-07-13 14:21 ` Greg Kurz
2017-07-13 14:49 ` Cornelia Huck
2017-07-14 10:29 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 5/8] virtio-blk: " Ladi Prosek
2017-07-13 14:54 ` Cornelia Huck
2017-07-14 10:29 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 6/8] virtio-net: " Ladi Prosek
2017-07-13 15:00 ` Cornelia Huck
2017-07-14 10:30 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 7/8] virtio-scsi: " Ladi Prosek
2017-07-13 15:03 ` Cornelia Huck
2017-07-14 10:30 ` Stefan Hajnoczi
2017-07-13 11:02 ` [Qemu-devel] [PATCH v2 8/8] virtio-crypto: " Ladi Prosek
2017-07-13 15:20 ` Cornelia Huck
2017-07-13 15:31 ` Ladi Prosek
2017-07-13 15:36 ` Cornelia Huck
2017-07-14 0:51 ` Gonglei (Arei)
2017-07-14 10:31 ` Stefan Hajnoczi
2017-07-13 14:36 ` [Qemu-devel] [PATCH v2 0/8] virtio: enhance virtio_error messages Greg Kurz
2017-07-13 15:00 ` Ladi Prosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABdb7367eVJNd8hWqVpF3RN58g7xchCyPLP=aaTy7jKXd8ws+A@mail.gmail.com' \
--to=lprosek@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=casasfernando@hotmail.com \
--cc=cohuck@redhat.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).