qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] meson: fix "static build" entry in summary
Date: Wed, 7 Jun 2023 11:26:35 +0200	[thread overview]
Message-ID: <CABgObfYJA=K0TXZP4tqaHrTG4N+nsFCOJsvLNM3-mXWsVY84cA@mail.gmail.com> (raw)
In-Reply-To: <f1c785b1-beac-55e1-7da9-d9a5f1ab77ff@linaro.org>

On Wed, Jun 7, 2023 at 11:09 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> On 7/6/23 11:03, Paolo Bonzini wrote:
> > Fixes: a0cbd2e8496 ("meson: use prefer_static option", 2023-05-18)
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >   meson.build | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 553c8e0b9c5..34d0444ffbb 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -4088,7 +4088,7 @@ summary_info += {'QEMU_LDFLAGS':      ' '.join(qemu_ldflags)}
> >   summary_info += {'profiler':          get_option('profiler')}
> >   summary_info += {'link-time optimization (LTO)': get_option('b_lto')}
> >   summary_info += {'PIE':               get_option('b_pie')}
> > -summary_info += {'static build':      config_host.has_key('CONFIG_STATIC')}
> > +summary_info += {'static build':      get_optin('prefer_static')}
>
> Typo 'get_option'.

Yeah, sent after testing but before committing the obvious fix. :(

Paolo

> >   summary_info += {'malloc trim support': has_malloc_trim}
> >   summary_info += {'membarrier':        have_membarrier}
> >   summary_info += {'debug graph lock':  get_option('debug_graph_lock')}
>



  reply	other threads:[~2023-06-07  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07  9:03 [PATCH] meson: fix "static build" entry in summary Paolo Bonzini
2023-06-07  9:08 ` Philippe Mathieu-Daudé
2023-06-07  9:26   ` Paolo Bonzini [this message]
2023-06-07  9:30     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfYJA=K0TXZP4tqaHrTG4N+nsFCOJsvLNM3-mXWsVY84cA@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).