From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43EE7C02198 for ; Sat, 8 Feb 2025 11:41:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgjC6-0003tm-8V; Sat, 08 Feb 2025 06:40:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgjC1-0003rH-Ha for qemu-devel@nongnu.org; Sat, 08 Feb 2025 06:40:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgjBz-0007iX-3i for qemu-devel@nongnu.org; Sat, 08 Feb 2025 06:40:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739014809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/3mXv4ELeiC2V6JPgnHvkqvzAX/X9skwIErg2J5nckg=; b=jJFuVog3Cq1BytaVo8v+kIdD4qfBg1JdiFuZFx1r1QxIQDsDWtgEGUvqBk+qpp6KtDXjLe DaCyHXIHVz37c+Qt6JG9ezzdPPgVEZ88guk+vT0VFuCxcEL7JwhAcXF5xbbdFZ3YqETy3X vJBE6kCRSYOCdrlmaukfIC12+gBTR5M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-vlex9O2sOcGJBla94t3mow-1; Sat, 08 Feb 2025 06:40:04 -0500 X-MC-Unique: vlex9O2sOcGJBla94t3mow-1 X-Mimecast-MFC-AGG-ID: vlex9O2sOcGJBla94t3mow Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43935bcec79so726865e9.3 for ; Sat, 08 Feb 2025 03:40:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739014802; x=1739619602; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/3mXv4ELeiC2V6JPgnHvkqvzAX/X9skwIErg2J5nckg=; b=bk2sFd/GjMJNTSNUhsxh0NJtQPI4ufADwEYZMsrerJBB/gkumeYRytVeNHScOVUCiY 0E677S9qp96YLO6usG1vPZbdW4Tu87dMnGpXRbHXF58C1SKXNaWTbknENUd+DHlo/4dQ 8swkv3orUbWdnvF4OK/W5BkfC4iJ36lKxOibZD3lVSVlGdzlQmWHNz5UY9u2HSk4sM92 kK7BH/lXpfjPF/sc6PrhTLvUrgS4yq1FQmm9/PP3fhl56hW96bYiurEPOEIdtDuUPMxu 7Ylw8D4qalzb6INPRs7JwOQ6Yv81aQQFJ+n/pBO/K24PiBdWGhWh7c99yTYxiNntsNZC W2Cw== X-Forwarded-Encrypted: i=1; AJvYcCUSlapL/zwf5f85L0i1VqFFzLM1DgKwySUulFbmqcu+lcz4Arh8v8qJDSuIalnmzK/NrmOkEPLpaSx4@nongnu.org X-Gm-Message-State: AOJu0YwWybiU83r3tc0W4CaVu9zp3YDAXu2JwrE0MTdFYKsN6Hr6UwOh rvJcK/CDkQUHODMRLjWIUrFyrvTh/Hr+CgnM4RcdBhATpsF8vI3IZnAlmhEIjTN5Fi3vuvdNa99 D91X9flSzTQciKB09FgTRJ0z+TFrbQ0+kw3LpQo2kTclQ02ZB4x56Lms5Ex67e30sq5tOvYTQ85 zVRAp613HbWqXCcHo2CdR+evIPm5M= X-Gm-Gg: ASbGncu72Ke0s7ljqgHWRc0NyQURbC837oeO4Vt7iEpyHTLhArlQ97HRnYzZqRLPOPx Dl4JupGYsAIEazRsxZPXf9i1+NHMS6HSNui6WFlpqq7AZsdaxb0QmqSqv+WSr X-Received: by 2002:a05:600c:3508:b0:434:9936:c823 with SMTP id 5b1f17b1804b1-43924994503mr60020025e9.18.1739014802672; Sat, 08 Feb 2025 03:40:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSEHpdn1iQEtAaZ19iiLEf/ZokcqJ/tMlEpRmFkQSZ4t2W3Mi7Ssw1i8k1FaDcg5mui26qNJ1gVzGD/B5mayk= X-Received: by 2002:a05:600c:3508:b0:434:9936:c823 with SMTP id 5b1f17b1804b1-43924994503mr60019925e9.18.1739014802374; Sat, 08 Feb 2025 03:40:02 -0800 (PST) MIME-Version: 1.0 References: <20250125125137.1223277-1-zhao1.liu@intel.com> <20250125125137.1223277-4-zhao1.liu@intel.com> <17907481-89d6-457c-bcd3-66a444b1325d@redhat.com> In-Reply-To: From: Paolo Bonzini Date: Sat, 8 Feb 2025 12:39:52 +0100 X-Gm-Features: AWEUYZmH99vpotQ0rtrXqSyInMaku2dIohEqkNdsQBDDZH7DrbhDDmAE4Gy9QpQ Message-ID: Subject: Re: [PATCH 03/10] rust/irq: Add a helper to convert [InterruptSource] to [*mut IRQState] To: Zhao Liu Cc: Manos Pitsidianakis , Junjie Mao , =?UTF-8?Q?Alex_Benn=EF=BF=BDe?= , =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVk77+9?= , Richard Henderson , Peter Maydell , =?UTF-8?B?RGFuaWVsIFAgLiBCZXJyYW5n77+9?= , qemu-devel , qemu-rust@nongnu.org Content-Type: multipart/alternative; boundary="0000000000008e1d04062d9fefc8" Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --0000000000008e1d04062d9fefc8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Il sab 8 feb 2025, 11:55 Zhao Liu ha scritto: > On Fri, Feb 07, 2025 at 10:57:11AM +0100, Paolo Bonzini wrote: > > Date: Fri, 7 Feb 2025 10:57:11 +0100 > > From: Paolo Bonzini > > Subject: Re: [PATCH 03/10] rust/irq: Add a helper to convert > > [InterruptSource] to [*mut IRQState] > > > > Il ven 7 feb 2025, 08:25 Zhao Liu ha scritto: > > > > > Just to confirm, I check with `cargo +nightly clippy` but it doesn't > > > complain about this case. Should I switch to another version of clipp= y > > > when I do such check? (currently I'm using v0.1.63 clippy as well, to > > > match rustc.) > > > > > > > I don't remember exactly how I noticed it=E2=80=94I am pretty sure it b= roke in CI > > though. Maybe the change to add rust_version hid it. > > > > To answer your question, generally the idea is that we use the latest > > version of the developer tools (cargo, rustfmt, clippy). In particular > old > > versions of cargo don't support retrieving clippy settings from > Cargo.toml. > > This one inspired me. I'm thinking that even though we deleted the > README of pl011, a gneral guide or doc section (at somewhere, e.g., > docs/devel/style.rst or docs/devel/submitting-a-patch.rst) would be > helpful. > > At least, that could remind contributor to check patches with latest > toolchain instead of letting the maintainer's CI smoking fail. > I have sent a docs/devel/rust.rst sometime last week, it will be in the next pull request and then you can send a patch on top. Paolo Thanks, > Zhao > > --0000000000008e1d04062d9fefc8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Il sab 8 feb 2025, 11:55 Zhao Li= u <zhao1.liu@intel.com> ha= scritto:
On Fri= , Feb 07, 2025 at 10:57:11AM +0100, Paolo Bonzini wrote:
> Date: Fri, 7 Feb 2025 10:57:11 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH 03/10] rust/irq: Add a helper to convert
>=C2=A0 [InterruptSource] to [*mut IRQState]
>
> Il ven 7 feb 2025, 08:25 Zhao Liu <zhao1.liu@intel.com> ha = scritto:
>
> > Just to confirm, I check with `cargo +nightly clippy` but it does= n't
> > complain about this case. Should I switch to another version of c= lippy
> > when I do such check? (currently I'm using v0.1.63 clippy as = well, to
> > match rustc.)
> >
>
> I don't remember exactly how I noticed it=E2=80=94I am pretty sure= it broke in CI
> though. Maybe the change to add rust_version hid it.
>
> To answer your question, generally the idea is that we use the latest<= br> > version of the developer tools (cargo, rustfmt, clippy). In particular= old
> versions of cargo don't support retrieving clippy settings from Ca= rgo.toml.

This one inspired me. I'm thinking that even though we deleted the
README of pl011, a gneral guide or doc section (at somewhere, e.g.,
docs/devel/style.rst or docs/devel/submitting-a-patch.rst) would be
helpful.

At least, that could remind contributor to check patches with latest
toolchain instead of letting the maintainer's CI smoking fail.

I have se= nt a docs/devel/rust.rst sometime last week, it will be in the next pull re= quest and then you can send a patch on top.

Paolo

Thanks,
Zhao

--0000000000008e1d04062d9fefc8--