Re: [PATCH 03/11] rust/qemu-api-macros: introduce Device proc macro

[Paolo Bonzini <pbonzini@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Manos,

I understand your desire to make fast progress, at the same time I can't
stress enough the importance of building on a shared design. Each
architectural decision we make now - whether about trait hierarchies, macro
designs, or API patterns - will significantly impact future maintenance and
development work.

The suggestions about how to split the implementation into smaller patches
aim to facilitate smaller and easier discussions about specific aspects,
and they are only examples and in no way the only possible solution.
However, with respect to design choices I think I pointed out major issues
that can't be treated simply as wanting to "do everything at once".
Dismissing design discussions as mere disagreements about style, or
responding confrontationally that you will address "bits that are wrong and
not much else" won't help us move forward. Code reviews, especially for
core APIs, necessarily include discussion of design choices and language
usage.

This isn't the first time our technical discussions have become tense, and
we're talking past each other at this point. My suggestion is that you try
to explain your point of view to a third person, that can help you
understand the patch review process and what is requested of both code
contributors and reviewers.

Thanks,

Paolo


Il dom 27 ott 2024, 23:40 Manos Pitsidianakis <
manos.pitsidianakis@linaro.org> ha scritto:

> Thank you for the review comments Paolo. I will address any bits I did
> wrong and not much the rest, it's obvious you have a disagreement over
> how things are done and that's fine. This series does not attempt to
> solve everything at once and arguing again and again over "this Trait
> should have been OtherTrait and this thing should have been thing!()"
> is not productive. Your review style of relentless disagreement after
> disagreement is tiresome and impossible to deal with; it's like a
> denial of service for other human beings. I suggest you take a step
> back and take a deep breath before reviewing Rust patches again. I
> assure you I will make sure to address all your comments either in
> code, TODO comments, or patch messages.
>
> In the meantime, take it easy.
>
>

[-- Attachment #2: Type: text/html, Size: 2896 bytes --]