From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F67C433E1 for ; Thu, 27 Aug 2020 09:20:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B72EC2080C for ; Thu, 27 Aug 2020 09:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g5nfTm4X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B72EC2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBE51-0000wM-SX for qemu-devel@archiver.kernel.org; Thu, 27 Aug 2020 05:20:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBDzx-0006WU-Ds for qemu-devel@nongnu.org; Thu, 27 Aug 2020 05:15:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kBDzu-0002JP-SY for qemu-devel@nongnu.org; Thu, 27 Aug 2020 05:15:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598519705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oo05j2vAVfkCxshf61MLeyKwpa5ecwh11SF/M1AByfk=; b=g5nfTm4XOp+ZPF8Jze33aJpLdxHArk8vQJuDac/ULDa3kkNllNK65W0iJYImh3yA1IF8ft QgsQK5iQN3cfTV6WL2BXT3IRkgoqOVHHzkhUvGNrJ4x5NVQwbEyyBU0YMNedvdOsOFCt0y pGSvwNpKlNMyB7IQS4WFqNdkttc3NXI= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-hNay5M8FP7q4nSC6pqQaLw-1; Thu, 27 Aug 2020 05:15:03 -0400 X-MC-Unique: hNay5M8FP7q4nSC6pqQaLw-1 Received: by mail-ej1-f71.google.com with SMTP id n12so2326166ejz.6 for ; Thu, 27 Aug 2020 02:15:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oo05j2vAVfkCxshf61MLeyKwpa5ecwh11SF/M1AByfk=; b=UwBjCoQJky6UDK9i76E/CiOeFzA4bffrvdh0T7iVLqjSPcsGyblHfu6EgFJXo+unYc jy7MJE4q4IoQGvXlgKcG7HSSMQVOojZgdlFCA6r8MYxxcvkF6IPSE3drCHvhQgWn7Lmb eVXcx3glDwnf6vSFgyip6Ihb6IArE4o7Sh6/VzwljuzVUlntJwRYHxQGdlZBxYFka4YE eGiUeb8K2QvP7c5+p2+0Hg27HLHYFh4uK5ua+60R4pMLUXZTvfx1txLKFI0ieVtvc5Cl ljJEBG6MgI+w7qjsxsxDyoH77IP++rcLKwH9ZuR97WMbPZ2CUWAm/PzoptngaizndZxz 4ieg== X-Gm-Message-State: AOAM533A8y+UXyyCrXnMpISMptGPcxdgYELxbuu5EgLoKbsbLS3ijva5 HO69iZmQtxh1NvMJO47s5UPaJomkva0m83zhh+iEJPu4nemYshSCnQnchXxpfg4WXmsT9VdoXbl I0HLF/B3XznUtF5FRg3/qzOvOVCGAwlw= X-Received: by 2002:aa7:da8e:: with SMTP id q14mr17239950eds.359.1598519701470; Thu, 27 Aug 2020 02:15:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCfLL8pIuo3zJ6RtzQLfCWbjRgn6KiG6JkxJV1kevYBY6uGB4y5fJW6NMgr5ZD83CzxZHmpDB0pif2P0HoiKU= X-Received: by 2002:aa7:da8e:: with SMTP id q14mr17239939eds.359.1598519701299; Thu, 27 Aug 2020 02:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20200826190128.22707-1-pbonzini@redhat.com> <3c7ca48a-5eb0-cfd4-bac0-a2a7475eec39@vivier.eu> In-Reply-To: From: Paolo Bonzini Date: Thu, 27 Aug 2020 11:14:49 +0200 Message-ID: Subject: Re: [PATCH] ninjatool: quote dollars in variables To: Laurent Vivier Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000f6860e05add85e01" Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/27 02:54:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.959, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000f6860e05add85e01 Content-Type: text/plain; charset="UTF-8" ... and actually it's fixed in 0.55.1. We can therefore just update the submodule and declare 0.55.1 the minimum required version for QEMU. Paolo Il gio 27 ago 2020, 11:10 Paolo Bonzini ha scritto: > Found; https://github.com/mesonbuild/Meson/issues/5191. > > (With the fix there's no rpath at all in the QEMU build process). > > Let's ask for a backport to 0.55.2. > > Paolo > > Il gio 27 ago 2020, 10:22 Paolo Bonzini ha scritto: > >> >> >> Il gio 27 ago 2020, 09:33 Laurent Vivier ha scritto: >> >>> This actually fixes the '-Wl,-rpath,$ORIGIN/', but doesn't fix the crash >>> with statically linked binaries. >>> >> >> I will try to reproduce when I am back; it works for Peter so there must >> be something different in the setup. >> >> In any case, if needed we can both momentarily hack around it in >> Makefiles, and fix it for good in Meson. >> >> Paolo >> >> >>> Could we simply remove the the '-Wl,-rpath,$ORIGIN/' in the case of >>> "-static" build? >>> >>> Thanks, >>> Laurent >>> >>> --000000000000f6860e05add85e01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
... and actually it's fixed in 0.55.1. We can therefo= re just update the submodule and declare 0.55.1 the minimum required versio= n for QEMU.

Paolo
<= br>
Il gio = 27 ago 2020, 11:10 Paolo Bonzini <pbonzini@redhat.com> ha scritto:
Found; https://github.com/mes= onbuild/Meson/issues/5191.

(With the fix there's no rpath at all in the QEMU build process).

Let's ask for a backport= to 0.55.2.

Paolo
<= /div>
I= l gio 27 ago 2020, 10:22 Paolo Bonzini <pbonzini@redhat.com> ha = scritto:

Il gi= o 27 ago 2020, 09:33 Laurent Vivier <laurent@vivier.eu>= ha scritto:
This actually fixes th= e '-Wl,-rpath,$ORIGIN/', but doesn't fix the crash
with statically linked binaries.

I will try to reproduce when I am back; it = works for Peter so there must be something different in the setup.

In any case, if needed we can bo= th momentarily hack around it in Makefiles, and fix it for good in Meson.

Paolo


Could we simply remove the the '-Wl,-rpath,$ORIGIN/' in the case of=
"-static" build?

Thanks,
Laurent

--000000000000f6860e05add85e01--