qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: "Volker Rümelin" <vr_qemu@t-online.de>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	eduardo@habkost.net, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT
Date: Fri, 26 Apr 2024 07:46:14 +0200	[thread overview]
Message-ID: <CABgObfYuAv6brH-C-jZtof-tTdMXLZP-fJz9jgQR5XsUB6F7wg@mail.gmail.com> (raw)
In-Reply-To: <d2e11eb2-4a4a-4e23-b200-3995ea865052@ilande.co.uk>

On Tue, Apr 23, 2024 at 10:42 PM Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
> > Let's change "Despite claims to the contrary" with "Despite a
> > confusing description".
>
> Thanks for sorting this, Paolo. I suspect that KVM needs a similar patch as per
> https://gitlab.com/qemu-project/qemu/-/issues/2198#note_1815726425 however the Win32s
> and OS/2 Warp 4 tests seem to work fine on KVM. Maybe it's because the SGDT and SIDT
> instructions run natively and don't need to be emulated for these cases?

Yes, they are almost never emulated (only in big real mode and only on
old Intel processors).

Paolo



      reply	other threads:[~2024-04-26  5:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 19:51 [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT Mark Cave-Ayland
2024-04-20  1:21 ` Richard Henderson
2024-04-20  5:40   ` Mark Cave-Ayland
2024-04-22 19:03     ` Volker Rümelin
2024-04-23  8:15       ` Philippe Mathieu-Daudé
2024-04-23  8:24         ` Daniel P. Berrangé
2024-04-23  9:18       ` Paolo Bonzini
2024-04-23 20:42         ` Mark Cave-Ayland
2024-04-26  5:46           ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABgObfYuAv6brH-C-jZtof-tTdMXLZP-fJz9jgQR5XsUB6F7wg@mail.gmail.com \
    --to=pbonzini@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).