From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpzJJ-00081l-MH for qemu-devel@nongnu.org; Thu, 07 Sep 2017 12:05:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpzJE-00070s-OH for qemu-devel@nongnu.org; Thu, 07 Sep 2017 12:05:45 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:33339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpzJE-000709-HS for qemu-devel@nongnu.org; Thu, 07 Sep 2017 12:05:40 -0400 Received: by mail-oi0-f41.google.com with SMTP id r20so883138oie.0 for ; Thu, 07 Sep 2017 09:05:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170902091520.bxecfhisvy46o4cb@aurel32.net> References: <20170901110332.32650-1-otubo@redhat.com> <20170901143016.GK7570@localhost.localdomain> <20170902091520.bxecfhisvy46o4cb@aurel32.net> From: Paolo Bonzini Date: Thu, 7 Sep 2017 18:05:37 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jarno, Aurelien" Cc: qemu-devel , "Gibson, David" , Eduardo Otubo , qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, Alexander Graf , mst@redhat.com, Eduardo Habkost Il 02 set 2017 11:17 AM, "Aurelien Jarno" ha scritto: On 2017-09-01 11:30, Eduardo Habkost wrote: > i82374 is compiled in only on ppc and sh4, so I'm CCing the > maintainers for those architectures. The i82374 device is not useful nor usable on SH4. It has just been added in commit 85d3846a39 to be able to run the tests. But that means that the patch is wrong and probably was not tested with "make check". Eduardo's proposal is the right one. Paolo Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net