qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"BALATON Zoltan" <balaton@eik.bme.hu>,
	"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH] docs: document what configure does with virtual environments
Date: Fri, 10 Nov 2023 10:10:27 +0100	[thread overview]
Message-ID: <CABgObfZddB2cTe2Ka9kh9rRYn1zkJQJcGiVZXMTF1cod=9tCyA@mail.gmail.com> (raw)
In-Reply-To: <CAFn=p-YB9QawiXd2newm1itooNpnU_4QY29zC2aFp2mN4beTHg@mail.gmail.com>

On Thu, Nov 9, 2023 at 10:35 PM John Snow <jsnow@redhat.com> wrote:
> > > +The venv resides in the ``pyvenv`` directory in the build tree,
> > > +and provides consistency in how the build process runs Python code.
> > > +In particular it avoids a potential mismatch, where Meson and Sphinx
> >
> > I think you can drop the comma. This is so pedantic that if you left
> > it in to spite me, I'd not blame you. :)

I'll keep it then. :)

> > should we say ``--sphinx-build``?

Yes, typo.

> > I also might say "does not ^necessarily pick the ..." because they
> > could be the same, it just isn't the criteria it uses to choose them.

I'll replace "pick" with "look for".

> > > +If QEMU does not find a dependency, check that it was installed in the
> > > +right ``site-packages`` directory or with the right ``pip`` program.
> >
> > I don't actually know what this means. >_>

It's meant to explain what happened with homebrew. Rephrased in v2:

This avoids a potential mismatch, where Meson and Sphinx binaries on the
PATH might operate in a different Python environment than the one chosen
by the user during the build process.  On the other hand, it introduces
a potential source of confusion where the user installs a dependency but
``configure`` is not able to find it.  When this happens, the dependency
was installed in the ``site-packages`` directory of another interpreter,
or with the wrong ``pip`` program.

Paolo



      reply	other threads:[~2023-11-10  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 15:58 [PATCH] docs: document what configure does with virtual environments Paolo Bonzini
     [not found] ` <CAFn=p-YZ=sMJ0=C71wX1x6NXcK8rSZfVO+f3TQQExADGJhEJdg@mail.gmail.com>
2023-11-09 21:35   ` John Snow
2023-11-10  9:10     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfZddB2cTe2Ka9kh9rRYn1zkJQJcGiVZXMTF1cod=9tCyA@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).