Re: [PATCH] hw/misc: applesmc: use host osk as default on macs

[Paolo Bonzini <pbonzini@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1933 bytes --]

Can you instead provide documentation in English (pseudocode, tables of the
structs, etc.)? That's the safest bet.

Paolo

El sáb., 9 oct. 2021 7:32, Pedro Tôrres <t0rr3sp3dr0@gmail.com> escribió:

> Hey Paolo and Phil,
>
> I understand you concerns regarding the license that Apple open-source
> code is distributed.
>
> If I restart from scratch and implement this feature based only on
> VirtualBox code, that is distributed under GPLv2, would it be fine?
>
> Best regards,
> Pedro Tôrres
>
> On Oct 8, 2021, at 3:54 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 08/10/21 14:03, Phil Dennis-Jordan wrote:
>
> 1. Licensing
>
> Given that the code it's heavily based on is copyright Apple Computer
> Inc., licensed under APSL, is it safe including it in qemu as is?
>
> If the integrated code is going to be quite so "directly inspired" (down
> to the inconsistent struct definition style and mixing unrelated constants
> in the same anonymous enum), perhaps at minimum place it in its own
> isolated source file with appropriate notice?
>
>
> Yeah, this should be reverted.
>
> Pedro, I understand that you stated it was "based on code from Apple" but
> you also said (by including Signed-off-by) that
>
> ---
> (a) The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
> ---
>
> and this is not true.
>
> Thanks very much,
>
> Paolo
>
>

[-- Attachment #2: Type: text/html, Size: 3176 bytes --]