From: Paolo Bonzini <pbonzini@redhat.com>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: qemu-devel@nongnu.org, flwu@google.com, berrange@redhat.com,
peter.maydell@linaro.org, rkir@google.com
Subject: Re: [PATCH] include: move typeof_strip_qual to compiler.h, use it in QAPI_LIST_LENGTH()
Date: Wed, 26 Jun 2024 23:32:26 +0200 [thread overview]
Message-ID: <CABgObfaK+CQTni9MQjTADY-Fode9Fg3hTqSfm+2K8R9DCRJ5cw@mail.gmail.com> (raw)
In-Reply-To: <fnhkw.xyx5xkm2lgb@linaro.org>
On Tue, Jun 25, 2024 at 9:17 PM Manos Pitsidianakis
<manos.pitsidianakis@linaro.org> wrote:
> >Move the macro to compiler.h and, while at it, move it under #ifndef
> >__cplusplus to emphasize that it uses C-only constructs. A C++ version
> >of typeof_strip_qual() using type traits is possible[1], but beyond the
> >scope of this patch because the little C++ code that is in QEMU does not
> >use QAPI.
>
> Should we add an #else to provide a fallback for cplusplus until the
> alternative is merged?
As the commit message says, I don't think we need to include the C++
code in QEMU since it would be essentially dead.
Paolo
next prev parent reply other threads:[~2024-06-26 21:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 11:18 [PATCH] include: move typeof_strip_qual to compiler.h, use it in QAPI_LIST_LENGTH() Paolo Bonzini
2024-06-25 18:31 ` Richard Henderson
2024-06-25 19:12 ` Manos Pitsidianakis
2024-06-26 21:30 ` Roman Kiryanov
2024-06-26 21:32 ` Paolo Bonzini [this message]
2024-06-27 8:34 ` Manos Pitsidianakis
2024-06-27 8:48 ` Paolo Bonzini
2024-06-27 8:53 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABgObfaK+CQTni9MQjTADY-Fode9Fg3hTqSfm+2K8R9DCRJ5cw@mail.gmail.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=flwu@google.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).