qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] ninjatool: quote dollars in variables
Date: Thu, 27 Aug 2020 06:13:03 +0200	[thread overview]
Message-ID: <CABgObfaO8TB=LYgpn871c82me8e83CzRuDYyi1UGWZFopLgfbQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8MSzo7+zSWTr8vmU294M3oYkZKk17SFRrBZLmqfxGdmQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Il mer 26 ago 2020, 21:34 Peter Maydell <peter.maydell@linaro.org> ha
scritto:

> On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > Otherwise, dollars (such as in the special $ORIGIN rpath) are
> > eaten by Make.
>
> Incidentally, why are we using rpath anyway? I'm pretty
> sure the old build system didn't need it, and it's one of
> those features I have mentally filed away under "liable
> to confusing and non-portable weirdness"...
>

It's only done in the build tree, to allow running against uninstalled
shared_library. Installed binaries have no rpath (distros don't want it
anyway). QEMU doesn't need it since it has no shared library yet.

Paolo

>

[-- Attachment #2: Type: text/html, Size: 1379 bytes --]

  reply	other threads:[~2020-08-27  4:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 19:01 [PATCH] ninjatool: quote dollars in variables Paolo Bonzini
2020-08-26 19:34 ` Peter Maydell
2020-08-27  4:13   ` Paolo Bonzini [this message]
2020-08-27  5:29     ` Alexander Bulekov
2020-08-27  7:33 ` Laurent Vivier
2020-08-27  8:22   ` Paolo Bonzini
2020-08-27  9:10     ` Paolo Bonzini
2020-08-27  9:14       ` Paolo Bonzini
2020-08-27 10:07         ` Peter Maydell
2020-08-27 12:02           ` Paolo Bonzini
2020-08-28 18:57         ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfaO8TB=LYgpn871c82me8e83CzRuDYyi1UGWZFopLgfbQ@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).