qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org, philmd@linaro.org
Subject: Re: [PATCH 05/10] hppa: do not require CONFIG_USB
Date: Sat, 24 Feb 2024 23:38:06 +0100	[thread overview]
Message-ID: <CABgObfaTc47kf7L5Jyh75KA__Jfzb-0cmOEwCRbPHOT8f=7qUQ@mail.gmail.com> (raw)
In-Reply-To: <ab8ce4b2-d0c4-867e-44cf-44137e91a610@eik.bme.hu>

On Fri, Feb 23, 2024 at 8:56 PM BALATON Zoltan <balaton@eik.bme.hu> wrote:
> >> -    if (!lasi_dev && machine->enable_graphics) {
> >> +    if (!lasi_dev && machine->enable_graphics && defaults_enabled()) {
> >
> > Do we need the defaults_enabled() here? Isn't enable_graphics already
> > disabled if defaults_enabled() is not set?
>
> Isn't enable_graphics controlled by -nographic and defaults_enabled
> controlled by -nodefaults? I think they are independent but maybe that
> does not answer the question if it's needed or not.

Indeed they are different. The idea is that if graphics are disabled
you interact with a serial console so you don't need keyboard or
mouse; and if default devices are disabled of course you create as
little as possible and leave everything to the user.

Paolo



  reply	other threads:[~2024-02-24 22:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 12:43 [PATCH 00/10] usb cleanups: remove usb_bus_find(), extract sysbus-ohci to a separate file Paolo Bonzini
2024-02-23 12:43 ` [PATCH 01/10] acpi, qom: move object_resolve_type_unambiguous to core QOM Paolo Bonzini
2024-02-23 17:02   ` Philippe Mathieu-Daudé
2024-02-26  7:00   ` Thomas Huth
2024-02-23 12:43 ` [PATCH 02/10] ppc: sam460ex: do not use usb_bus_find() Paolo Bonzini
2024-02-26  7:03   ` Thomas Huth
2024-02-26  7:39   ` Markus Armbruster
2024-02-26  7:41     ` Markus Armbruster
2024-02-26 10:46       ` BALATON Zoltan
2024-02-26  7:42   ` Markus Armbruster
2024-02-23 12:43 ` [PATCH 03/10] sh4: r2d: " Paolo Bonzini
2024-02-26  7:04   ` Thomas Huth
2024-02-23 12:44 ` [PATCH 04/10] mips/loongson3_virt: do not require CONFIG_USB Paolo Bonzini
2024-02-26  7:05   ` Thomas Huth
2024-02-26  7:42   ` Markus Armbruster
2024-02-23 12:44 ` [PATCH 05/10] hppa: " Paolo Bonzini
2024-02-23 17:19   ` Philippe Mathieu-Daudé
2024-02-23 19:23   ` Thomas Huth
2024-02-23 19:56     ` BALATON Zoltan
2024-02-24 22:38       ` Paolo Bonzini [this message]
2024-02-26  6:56         ` Thomas Huth
2024-02-23 12:44 ` [PATCH 06/10] mac_newworld: " Paolo Bonzini
2024-02-23 17:20   ` Philippe Mathieu-Daudé
2024-02-23 12:44 ` [PATCH 07/10] pseries: " Paolo Bonzini
2024-02-23 17:32   ` Philippe Mathieu-Daudé
2024-02-23 17:47     ` Paolo Bonzini
2024-02-23 12:44 ` [PATCH 08/10] usb: remove usb_bus_find Paolo Bonzini
2024-02-23 17:03   ` Philippe Mathieu-Daudé
2024-02-23 12:44 ` [PATCH 09/10] usb: extract sysbus-ohci to a separate file Paolo Bonzini
2024-02-23 17:10   ` Philippe Mathieu-Daudé
2024-02-26  7:14   ` Thomas Huth
2024-02-23 12:44 ` [PATCH 10/10] usb: remove duplicate file in system_ss Paolo Bonzini
2024-02-23 17:40   ` Philippe Mathieu-Daudé
2024-02-26  7:57 ` [PATCH 00/10] usb cleanups: remove usb_bus_find(), extract sysbus-ohci to a separate file Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgObfaTc47kf7L5Jyh75KA__Jfzb-0cmOEwCRbPHOT8f=7qUQ@mail.gmail.com' \
    --to=pbonzini@redhat.com \
    --cc=balaton@eik.bme.hu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).