From: Paolo Bonzini <pbonzini@redhat.com>
To: luoyonggang@gmail.com
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2
Date: Wed, 26 Aug 2020 17:36:01 +0200 [thread overview]
Message-ID: <CABgObfagsQcHhAFTfDcqH5hWOzrwuHocygu10uWO7XR8BPmyEw@mail.gmail.com> (raw)
In-Reply-To: <CAE2XoE-mG9PFZF3hA4XpZ62oUicMQDid5AMqvUbx+yoOfLY=EQ@mail.gmail.com>
On Wed, Aug 26, 2020 at 5:33 PM 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> wrote:
>
>
> On Wed, Aug 26, 2020 at 11:24 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>> I'm a bit wary of this patch, the effects are quite wide-ranging. If
>> we move all the detection of dependencies to meson, it will take a
>> while but we should get a similar effect.
>
> Only on MINGW the $PWD sematic are changed, so I don't think there is side effect of this patch.
Yes the side effect is only on MINGW but the affected variables are
used everywhere so it's a rather hard to review change.
Paolo
next prev parent reply other threads:[~2020-08-26 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:10 [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja luoyonggang
2020-08-26 15:10 ` [PATCH v5 2/6] meson: fixes relpath may fail on win32 luoyonggang
2020-08-26 15:10 ` [PATCH v5 3/6] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-26 15:10 ` [PATCH v5 4/6] configure: Fix include and linkage issue on msys2 luoyonggang
2020-08-26 15:24 ` Paolo Bonzini
2020-08-26 15:33 ` 罗勇刚(Yonggang Luo)
2020-08-26 15:36 ` Paolo Bonzini [this message]
2020-08-26 15:38 ` 罗勇刚(Yonggang Luo)
2020-08-27 16:14 ` Mark Cave-Ayland
2020-08-26 15:10 ` [PATCH v5 5/6] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2 luoyonggang
2020-08-26 15:10 ` [PATCH v5 6/6] meson: Convert undefsym.sh to undefsym.py luoyonggang
2020-08-26 15:22 ` Paolo Bonzini
2020-08-26 15:27 ` 罗勇刚(Yonggang Luo)
2020-08-26 15:28 ` [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja Paolo Bonzini
2020-08-26 15:31 ` 罗勇刚(Yonggang Luo)
2020-08-26 15:36 ` Paolo Bonzini
2020-08-26 15:39 ` 罗勇刚(Yonggang Luo)
2020-08-26 15:41 ` Paolo Bonzini
2020-08-26 15:45 ` 罗勇刚(Yonggang Luo)
2020-08-26 15:47 ` 罗勇刚(Yonggang Luo)
2020-08-26 15:56 ` Paolo Bonzini
2020-08-26 16:09 ` 罗勇刚(Yonggang Luo)
2020-08-26 16:17 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABgObfagsQcHhAFTfDcqH5hWOzrwuHocygu10uWO7XR8BPmyEw@mail.gmail.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).