From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Aldy Hernandez <aldyh@redhat.com>, Thomas Huth <thuth@redhat.com>,
Gavin Shan <gshan@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>,
qemu-arm <qemu-arm@nongnu.org>, Shan Gavin <shan.gavin@gmail.com>,
Philippe Mathieu Daude <philmd@redhat.com>
Subject: Re: [PATCH] configure: Improve alias attribute check
Date: Sun, 21 Mar 2021 18:43:08 +0100 [thread overview]
Message-ID: <CABgObfbG701a-_TB2v7irYe1DpPY-_zExgJ4SPMfyUEJD_2uXw@mail.gmail.com> (raw)
In-Reply-To: <fefde0c1-5670-7cd5-4f7c-ab11af6aeb62@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
Il dom 21 mar 2021, 18:34 Richard Henderson <richard.henderson@linaro.org>
ha scritto:
> On 3/21/21 10:50 AM, Paolo Bonzini wrote:
> > Another workaround may be to avoid compiling exec-vary.c with
> -flto. I'm not
> > sure that my meson fu is up to that. Paolo?
> >
> > You would have to define a static library.
>
> Ok. With an extra -fno-lto flag, or can I somehow remove -flto from the
> library's cflags? Or unset the meson b_lto variable?
>
-fno-lto should work, yes. b_lto tries to cater to other compilers, but we
don't support anything but gcc-like drivers.
> I have filed a gcc bug report:
> >
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99696
> >
> > Hopefully someone can address that before gcc 11 gets released. At
> which
> > point we need do nothing in qemu. Aldy?
>
> So, I've reproduced the testcase failure with gcc 9.3 (ubuntu 20.04) as
> well.
> Which means that there are at least two releases for which this has not
> worked.
>
> I think Gavin's runtime test is unnecessary. We don't have to check the
> runtime results, we can just [ "$lto" = true ], and we fairly well know
> it'll fail.
>
Yeah, if anything the test can be used to re-enable attribute((alias)) once
we know there are some fixed compilers. (Though it's quite ugly to have
worse compilation when cross-compiling).
Paolo
>
> r~
>
>
[-- Attachment #2: Type: text/html, Size: 2445 bytes --]
next prev parent reply other threads:[~2021-03-21 17:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 4:27 [PATCH] configure: Improve alias attribute check Gavin Shan
2021-03-20 4:48 ` Thomas Huth
2021-03-20 23:32 ` Gavin Shan
2021-03-20 17:52 ` Paolo Bonzini
2021-03-20 22:33 ` Richard Henderson
2021-03-20 23:36 ` Gavin Shan
2021-03-21 15:49 ` Richard Henderson
2021-03-21 16:50 ` Paolo Bonzini
2021-03-21 17:34 ` Richard Henderson
2021-03-21 17:43 ` Paolo Bonzini [this message]
2021-03-21 17:46 ` Paolo Bonzini
2021-03-21 18:23 ` Richard Henderson
2021-03-22 10:54 ` Gavin Shan
2021-03-22 20:59 ` Richard Henderson
2021-03-23 3:13 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABgObfbG701a-_TB2v7irYe1DpPY-_zExgJ4SPMfyUEJD_2uXw@mail.gmail.com \
--to=pbonzini@redhat.com \
--cc=aldyh@redhat.com \
--cc=gshan@redhat.com \
--cc=laurent@vivier.eu \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).