From: Paolo Bonzini <pbonzini@redhat.com>
To: Pankaj Gupta <pankaj.gupta@amd.com>
Cc: qemu-devel@nongnu.org, brijesh.singh@amd.com,
dovmurik@linux.ibm.com, armbru@redhat.com, michael.roth@amd.com,
xiaoyao.li@intel.com, thomas.lendacky@amd.com,
isaku.yamahata@intel.com, berrange@redhat.com,
kvm@vger.kernel.org, anisinha@redhat.com
Subject: Re: [PATCH v4 10/31] i386/sev: Add snp_kvm_init() override for SNP class
Date: Fri, 31 May 2024 13:07:36 +0200 [thread overview]
Message-ID: <CABgObfbVb-=QiyDMKBHarrmr5pxs2NudKPCLZZgvCX14as2SDA@mail.gmail.com> (raw)
In-Reply-To: <20240530111643.1091816-11-pankaj.gupta@amd.com>
On Thu, May 30, 2024 at 1:17 PM Pankaj Gupta <pankaj.gupta@amd.com> wrote:
> + } else if (x86ms->smm == ON_OFF_AUTO_ON) {
> + error_setg(errp, "SEV-SNP does not support SMM.");
> + ram_block_discard_disable(false);
Unnecessary line, there is no matching ram_block_discard_disable(true).
Paolo
next prev parent reply other threads:[~2024-05-31 11:08 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 11:16 [PATCH v4 00/31] Add AMD Secure Nested Paging (SEV-SNP) support Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 01/31] i386/sev: Replace error_report with error_setg Pankaj Gupta
2024-06-03 11:57 ` Daniel P. Berrangé
2024-05-30 11:16 ` [PATCH v4 02/31] linux-headers: Update to current kvm/next Pankaj Gupta
2024-05-31 14:38 ` Liam Merwick via
2024-05-31 15:37 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 03/31] memory: Introduce memory_region_init_ram_guest_memfd() Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 04/31] i386/sev: Introduce "sev-common" type to encapsulate common SEV state Pankaj Gupta
2024-05-31 11:03 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 05/31] i386/sev: Move sev_launch_update to separate class method Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 06/31] i386/sev: Move sev_launch_finish " Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 07/31] i386/sev: Introduce 'sev-snp-guest' object Pankaj Gupta
2024-05-31 11:06 ` Paolo Bonzini
2024-06-03 12:02 ` Daniel P. Berrangé
2024-06-03 17:48 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 08/31] i386/sev: Add a sev_snp_enabled() helper Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 09/31] i386/sev: Add sev_kvm_init() override for SEV class Pankaj Gupta
2024-05-31 11:06 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 10/31] i386/sev: Add snp_kvm_init() override for SNP class Pankaj Gupta
2024-05-31 11:07 ` Paolo Bonzini [this message]
2024-05-30 11:16 ` [PATCH v4 11/31] i386/cpu: Set SEV-SNP CPUID bit when SNP enabled Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 12/31] i386/sev: Don't return launch measurements for SEV-SNP guests Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 13/31] i386/sev: Add a class method to determine KVM VM type for SNP guests Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 14/31] i386/sev: Update query-sev QAPI format to handle SEV-SNP Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 15/31] i386/sev: Add the SNP launch start context Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 16/31] i386/sev: Add handling to encrypt/finalize guest launch data Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 17/31] i386/sev: Set CPU state to protected once SNP guest payload is finalized Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 18/31] hw/i386/sev: Add function to get SEV metadata from OVMF header Pankaj Gupta
2024-05-31 15:19 ` Liam Merwick via
2024-05-31 15:41 ` Paolo Bonzini
2024-05-31 16:41 ` Liam Merwick via
2024-05-30 11:16 ` [PATCH v4 19/31] i386/sev: Add support for populating OVMF metadata pages Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 20/31] i386/sev: Add support for SNP CPUID validation Pankaj Gupta
2024-07-02 3:07 ` Xiaoyao Li
2024-07-04 0:34 ` Michael Roth
2024-07-04 4:09 ` Xiaoyao Li
2024-07-04 5:31 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 21/31] i386/sev: Extract build_kernel_loader_hashes Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 22/31] i386/sev: Reorder struct declarations Pankaj Gupta
2024-05-31 11:12 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 23/31] i386/sev: Allow measured direct kernel boot on SNP Pankaj Gupta
2024-05-31 11:14 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 24/31] hw/i386/sev: Add support to encrypt BIOS when SEV-SNP is enabled Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 25/31] i386/sev: Invoke launch_updata_data() for SEV class Pankaj Gupta
2024-05-31 11:10 ` Paolo Bonzini
2024-05-30 11:16 ` [PATCH v4 26/31] i386/sev: Invoke launch_updata_data() for SNP class Pankaj Gupta
2024-05-30 11:16 ` [PATCH v4 27/31] hw/i386/sev: Use guest_memfd for legacy ROMs Pankaj Gupta
2024-05-31 11:27 ` Paolo Bonzini
2024-06-14 8:58 ` Xiaoyao Li
2024-06-14 10:02 ` Gupta, Pankaj
2024-05-30 11:16 ` [PATCH v4 28/31] hw/i386: Add support for loading BIOS using guest_memfd Pankaj Gupta
2024-05-31 11:22 ` Paolo Bonzini
2024-06-14 8:34 ` Xiaoyao Li
2024-06-14 8:48 ` Gupta, Pankaj
2024-06-14 9:03 ` Xiaoyao Li
2024-05-30 11:16 ` [PATCH v4 29/31] hw/i386/sev: Allow use of pflash in conjunction with -bios Pankaj Gupta
2024-05-31 12:33 ` Paolo Bonzini
2024-06-03 11:55 ` Daniel P. Berrangé
2024-06-03 13:38 ` Paolo Bonzini
2024-06-04 9:03 ` Hoffmann, Gerd
2024-06-03 14:27 ` Michael Roth via
2024-06-03 14:31 ` Paolo Bonzini
2024-06-03 16:31 ` Michael Roth
2024-05-30 11:16 ` [PATCH v4 30/31] i386/kvm: Add KVM_EXIT_HYPERCALL handling for KVM_HC_MAP_GPA_RANGE Pankaj Gupta
2024-07-04 8:53 ` Binbin Wu
2024-05-30 11:16 ` [PATCH v4 31/31] i386/sev: Enable KVM_HC_MAP_GPA_RANGE hcall for SNP guests Pankaj Gupta
2024-05-31 11:20 ` [PATCH v4 00/31] Add AMD Secure Nested Paging (SEV-SNP) support Paolo Bonzini
2024-05-31 17:34 ` Paolo Bonzini
2024-05-31 17:40 ` Gupta, Pankaj
2024-05-31 17:53 ` Paolo Bonzini
2024-06-01 4:57 ` Gupta, Pankaj
2024-06-03 14:15 ` Michael Roth
2024-06-03 14:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgObfbVb-=QiyDMKBHarrmr5pxs2NudKPCLZZgvCX14as2SDA@mail.gmail.com' \
--to=pbonzini@redhat.com \
--cc=anisinha@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=dovmurik@linux.ibm.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pankaj.gupta@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=thomas.lendacky@amd.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).