From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] util/log: Always send errors to logfile when daemonized
Date: Fri, 14 Oct 2022 20:28:09 +0200 [thread overview]
Message-ID: <CABgObfbg0H+gToK4=5950DiZUQVYFMdDZMq_BMynnAicMHz4sg@mail.gmail.com> (raw)
In-Reply-To: <20221014180714.6d423f74@bahia>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Il ven 14 ott 2022, 18:07 Greg Kurz <groug@kaod.org> ha scritto:
> 2) and 3) can certainly be preparatory work but I think 1)
> should be squashed in my patch. Because of the !per_thread
> check in need_to_open_file, the existing code in
> qemu_set_log_internal() doesn't even open the global file
> and qemu_log_trylock() would always return NULL for the
> main thread.
>
Sounds good, thanks!
Paolo
> Thanks for the quick answer and suggestions !
>
> > Paolo
> >
>
>
[-- Attachment #2: Type: text/html, Size: 1078 bytes --]
prev parent reply other threads:[~2022-10-14 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 6:08 [PATCH] util/log: Always send errors to logfile when daemonized Greg Kurz
2022-10-14 8:51 ` Paolo Bonzini
2022-10-14 16:07 ` Greg Kurz
2022-10-14 18:28 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgObfbg0H+gToK4=5950DiZUQVYFMdDZMq_BMynnAicMHz4sg@mail.gmail.com' \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).