Re: [PULL 16/41] hw/i386: Remove linuxboot.bin

[Paolo Bonzini <pbonzini@redhat.com>]

On Tue, Mar 24, 2026 at 1:12 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Thu, Feb 12, 2026 at 03:42:18PM +0100, Paolo Bonzini wrote:
> > From: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> > All machines now use the linuxboot_dma.bin binary, so it's safe to
> > remove the non-DMA version (linuxboot.bin).
> >
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > Link: https://lore.kernel.org/r/20260108033051.777361-16-zhao1.liu@intel.com
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  hw/i386/pc.c                  |   3 +-
> >  pc-bios/meson.build           |   1 -
> >  pc-bios/optionrom/Makefile    |   2 +-
> >  pc-bios/optionrom/linuxboot.S | 195 ----------------------------------
> >  4 files changed, 2 insertions(+), 199 deletions(-)
> >  delete mode 100644 pc-bios/optionrom/linuxboot.S
>
> The pre-built  pc-bios/linuxboot_dma.bin  still exists in the tree,
> shouldn't that have been deleted too ?

I think you mean pc-bios/linuxboot.bin - yeah, that one should go as well.

Paolo