From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57699)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1WQJQN-0000vZ-1w
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 12:33:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1WQJQM-00023o-2j
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 12:33:02 -0400
Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:35029)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1WQJQL-00022m-Tr
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 12:33:02 -0400
Received: by mail-ob0-f169.google.com with SMTP id va2so8456460obc.28
	for <qemu-devel@nongnu.org>; Wed, 19 Mar 2014 09:33:01 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1395245708-22971-1-git-send-email-peter.maydell@linaro.org>
References: <1395245708-22971-1-git-send-email-peter.maydell@linaro.org>
Date: Wed, 19 Mar 2014 17:33:01 +0100
Message-ID: <CABoDooM_GJexCumYT6HswVDY47xeta=68M9C-fTGQZXuoHYXsQ@mail.gmail.com>
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH buildfix for-2.0] linux-user: Fix build if
 headers don't define _LINUX_CAPABILITY_VERSION_1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

On Wed, Mar 19, 2014 at 5:15 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> Older kernel headers don't define _LINUX_CAPABILITY_VERSION_1.
> Switch to using the older _LINUX_CAPABILITY_VERSION; newer headers
> still define this for source compatibility.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>

I'm not sure I should send "Reviewed-by" for issues I reported,
but here it is.

Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>

Thanks,

Laurent

> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 366b695..2eac6d5 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -7698,7 +7698,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>          header.version = tswap32(target_header->version);
>          header.pid = tswap32(target_header->pid);
>
> -        if (header.version != _LINUX_CAPABILITY_VERSION_1) {
> +        if (header.version != _LINUX_CAPABILITY_VERSION) {
>              /* Version 2 and up takes pointer to two user_data structs */
>              data_items = 2;
>          }
> --
> 1.9.0
>