From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72E1C2BBFD for ; Mon, 13 Apr 2020 16:19:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3F0520732 for ; Mon, 13 Apr 2020 16:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BxSh0R4y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3F0520732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO1o0-00030P-Rz for qemu-devel@archiver.kernel.org; Mon, 13 Apr 2020 12:19:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60565) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jO1nG-0002X7-Is for qemu-devel@nongnu.org; Mon, 13 Apr 2020 12:18:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jO1n2-0000jG-8Z for qemu-devel@nongnu.org; Mon, 13 Apr 2020 12:18:33 -0400 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]:40278) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jO1n2-0000ia-0i; Mon, 13 Apr 2020 12:18:28 -0400 Received: by mail-io1-xd44.google.com with SMTP id w1so9885768iot.7; Mon, 13 Apr 2020 09:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mzPHCw6k3Pu8SILTY74WR97yZG/8zldYlE/UmI9Oxfw=; b=BxSh0R4ypxaasNyCRZSHTvLhTLpjwkOWU6zR2afdxlsp9H8sATX2DEFIHIphpjPVJd 1isTPCAYW9/N46CnT7bQovV4W/Z9DzViiJQRPwUQ1Lx7Wd4vANHuHxcZYM6EMHj3842T D3CpLNcsFvDb9E5M90AAKy9/Q1BrHIF6w+UZOmGgyiOKbmgbnAOqv8+Cw9MNVAR5Kgb5 lr8T3SQK/D5YOEYjFHyRab5N9I0tMt+sjcT4KbfMlbEZbOlwY8xSyM4FlMTjpHPyZN5t zT0WL8iY/St82s0/QfabhbAt2qUuih3UjCenFdtoGkf9+7i00oRBnpc0fH/zg9KwYIXp ZXeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mzPHCw6k3Pu8SILTY74WR97yZG/8zldYlE/UmI9Oxfw=; b=P5FMGnUmFe7luvJ2S0rdG6U53uoqKmRrBGpHdi//34Uje0N+yuo2HNwUJh2D3cKUSK R4JHPt6dWGYydM4ftQuwbgVkmD7TPI1G+DHHP9xBw3PZZxKCx/R3B3pjoCH+C/BFgeao +6JPKwsdTbUYHCUCaPTXy6HNIAqutwiL5Uu8XpGGAa4sXJK1FKmcSfyq5oRrjYTQGSET rWKcyeG7PYwu8UUVBuCjwcRzzqzOqYoQDYG2mRyqMpHX+LRqyoY8ujKzqU0BTjxao7EP k1M7yAY0jMqhLN0731g+8CU11UMSwAPUtjwCuBA7epAcxWygV0h3kLlUC+Od26GgPwI+ k3hA== X-Gm-Message-State: AGi0PuZKxnm116HaycR5aD2apmJrnMpewaLRqkoy51rmFv5Qe1MKgfCR NdBOqogdSxiS2wMD2mtltTtUv+ZTv3arqpM7tUgb1fN1IHE= X-Google-Smtp-Source: APiQypKq45FTmSYWlNHE3GiBs0EYMUYz3pj1XwmEfghVLI9laq/vE1/M2JdFTRj6QX5H6K2GqkhdN7cZlr09krV0qZ4= X-Received: by 2002:a6b:148:: with SMTP id 69mr16744386iob.189.1586794707213; Mon, 13 Apr 2020 09:18:27 -0700 (PDT) MIME-Version: 1.0 References: <20200326230838.31112-1-richard.henderson@linaro.org> <20200326230838.31112-23-richard.henderson@linaro.org> In-Reply-To: <20200326230838.31112-23-richard.henderson@linaro.org> From: Laurent Desnogues Date: Mon, 13 Apr 2020 18:18:23 +0200 Message-ID: Subject: Re: [PATCH 22/31] target/arm: Implement SVE2 integer add/subtract long with carry To: Richard Henderson Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d44 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rajav@quicinc.com, qemu-arm , "qemu-devel@nongnu.org" , apazos@quicinc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Mar 27, 2020 at 12:17 AM Richard Henderson wrote: [...] > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index a0995d95c7..aa330f75c3 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c [...] > +void HELPER(sve2_adcl_d)(void *vd, void *va, void *vn, void *vm, uint32_t desc) > +{ > + intptr_t i, opr_sz = simd_oprsz(desc); > + int sel = extract32(desc, SIMD_DATA_SHIFT, 1) * 32; > + uint64_t inv = -(uint64_t)extract32(desc, SIMD_DATA_SHIFT + 1, 1); > + uint64_t *d = vd, *a = va, *n = vn, *m = vm; > + > + for (i = 0; i < opr_sz / 8; i += 2) { > + Int128 e1 = int128_make64(a[i]); > + Int128 e2 = int128_make64(n[i + sel] ^ inv); > + Int128 c = int128_make64(m[i + 1] & 1); > + Int128 r = int128_add(int128_add(e1, e2), c); > + d[i + 0] = int128_getlo(r); > + d[i + 1] = int128_gethi(r); > + } > +} sel should not be multiplied by 32. Laurent