From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1XczaN-0000zK-1K
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 12:32:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1XczaM-0002Nx-8g
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 12:32:02 -0400
Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]:38594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1XczaM-0002Nr-3p
	for qemu-devel@nongnu.org; Sat, 11 Oct 2014 12:32:02 -0400
Received: by mail-oi0-f42.google.com with SMTP id a141so9700789oig.1
	for <qemu-devel@nongnu.org>; Sat, 11 Oct 2014 09:32:01 -0700 (PDT)
MIME-Version: 1.0
Date: Sat, 11 Oct 2014 18:32:01 +0200
Message-ID: <CABoDooO81WUcsq+NmgNuerouzCPGoYYq1Er0XCDVVmDrFTnTOg@mail.gmail.com>
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] AArch64: duplicate store in do_fp_st
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

Hello,

in target-arm/translate-a64.c:do_fp_st, it looks like there's an
extraneous store:

        TCGv_i64 tcg_hiaddr = tcg_temp_new_i64();
        tcg_gen_qemu_st_i64(tmp, tcg_addr, get_mem_index(s), MO_TEQ);
        tcg_gen_qemu_st64(tmp, tcg_addr, get_mem_index(s));

The second one can safely be removed.

Thanks,

Laurent