From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1Z0nh2-0003sp-3D
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 05:13:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1Z0nh1-0006fm-5V
	for qemu-devel@nongnu.org; Fri, 05 Jun 2015 05:13:36 -0400
MIME-Version: 1.0
In-Reply-To: <1433495103-62084-1-git-send-email-agraf@suse.de>
References: <1433495103-62084-1-git-send-email-agraf@suse.de>
Date: Fri, 5 Jun 2015 11:13:34 +0200
Message-ID: <CABoDooOY_b+Jo0PEXAACnTicV9xHSN68d9CKRr6ckD9okMHtiQ@mail.gmail.com>
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] machine: Drop use of DEFAULT_RAM_SIZE in
	help text
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-ppc@nongnu.org, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, David Gibson <david@gibson.dropbear.id.au>

On Fri, Jun 5, 2015 at 11:05 AM, Alexander Graf <agraf@suse.de> wrote:
> As of commit 076b35b5a (machine: add default_ram_size to machine class) we
> no longer have a global default ram size, but instead machine specific
> defaults. When invoking qemu --help we don't know which machine you selected,
> so we can't tell the user the default RAM size in the help text anymore now.
>
> Thus I don't see an easy way to expose the default ram size to the user in the
> help text. The easiest option IMHO is to just drop this piece of information.

It's unfortunate, but I agree.

Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>

Thanks,

Laurent

> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  qemu-options.hx | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index b3db6cb..5eaba11 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -241,8 +241,7 @@ ETEXI
>  DEF("m", HAS_ARG, QEMU_OPTION_m,
>      "-m[emory] [size=]megs[,slots=n,maxmem=size]\n"
>      "                configure guest RAM\n"
> -    "                size: initial amount of guest memory (default: "
> -    stringify(DEFAULT_RAM_SIZE) "MiB)\n"
> +    "                size: initial amount of guest memory\n"
>      "                slots: number of hotplug slots (default: none)\n"
>      "                maxmem: maximum amount of guest memory (default: none)\n"
>      "NOTE: Some architectures might enforce a specific granularity\n",
> --
> 1.8.1.4
>