From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [Aarch64] Bug in add/sub extended reg
Date: Thu, 20 Feb 2014 12:51:37 +0100 [thread overview]
Message-ID: <CABoDooOnS3Rn3e307ZnC2vDoD8ha+eiEftitz=vKjmaaOoo=0g@mail.gmail.com> (raw)
Hello,
there's a bug in SP handling in disas_add_sub_ext_reg:
/* non-flag setting ops may use SP */
if (!setflags) {
tcg_rn = read_cpu_reg_sp(s, rn, sf);
tcg_rd = cpu_reg_sp(s, rd);
} else {
tcg_rn = read_cpu_reg(s, rn, sf);
tcg_rd = cpu_reg(s, rd);
}
rn can always be SP no matter whether flags are set or not.
Thanks,
Laurent
next reply other threads:[~2014-02-20 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 11:51 Laurent Desnogues [this message]
2014-02-20 12:25 ` [Qemu-devel] [Aarch64] Bug in add/sub extended reg Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABoDooOnS3Rn3e307ZnC2vDoD8ha+eiEftitz=vKjmaaOoo=0g@mail.gmail.com' \
--to=laurent.desnogues@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).