From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40204)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1WGSAF-0006u6-6S
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:51:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1WGSAE-0007dd-B7
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:51:39 -0500
Received: from mail-oa0-x231.google.com ([2607:f8b0:4003:c02::231]:64432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent.desnogues@gmail.com>) id 1WGSAE-0007dW-57
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:51:38 -0500
Received: by mail-oa0-f49.google.com with SMTP id i7so1955698oag.36
	for <qemu-devel@nongnu.org>; Thu, 20 Feb 2014 03:51:37 -0800 (PST)
MIME-Version: 1.0
Date: Thu, 20 Feb 2014 12:51:37 +0100
Message-ID: <CABoDooOnS3Rn3e307ZnC2vDoD8ha+eiEftitz=vKjmaaOoo=0g@mail.gmail.com>
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: [Qemu-devel] [Aarch64] Bug in add/sub extended reg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Hello,

there's a bug in SP handling in disas_add_sub_ext_reg:

    /* non-flag setting ops may use SP */
    if (!setflags) {
        tcg_rn = read_cpu_reg_sp(s, rn, sf);
        tcg_rd = cpu_reg_sp(s, rd);
    } else {
        tcg_rn = read_cpu_reg(s, rn, sf);
        tcg_rd = cpu_reg(s, rd);
    }

rn can always be SP no matter whether flags are set or not.

Thanks,

Laurent