* [PATCH] qapi: Document QCryptodevBackendServiceType
@ 2024-08-12 1:42 zhenwei pi
2024-08-12 6:14 ` Philippe Mathieu-Daudé
2024-09-05 10:45 ` Markus Armbruster
0 siblings, 2 replies; 7+ messages in thread
From: zhenwei pi @ 2024-08-12 1:42 UTC (permalink / raw)
To: armbru; +Cc: eblake, qemu-devel, arei.gonglei, zhenwei pi
QCryptodevBackendServiceType was introduced by
bc304a6442e (cryptodev: Introduce server type in QAPI). However there
is a lack of member description. Thanks to Markus for pointing out
this.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
qapi/cryptodev.json | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
index 68289f4984..9622c6d92b 100644
--- a/qapi/cryptodev.json
+++ b/qapi/cryptodev.json
@@ -28,6 +28,16 @@
#
# The supported service types of a crypto device.
#
+# @cipher: Symmetric Key Cipher service
+#
+# @hash: Hash service
+#
+# @mac: Message Authentication Codes service
+#
+# @aead: Authenticated Encryption with Associated Data service
+#
+# @akcipher: Asymmetric Key Cipher service
+#
# Since: 8.0
##
{ 'enum': 'QCryptodevBackendServiceType',
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] qapi: Document QCryptodevBackendServiceType
2024-08-12 1:42 [PATCH] qapi: Document QCryptodevBackendServiceType zhenwei pi
@ 2024-08-12 6:14 ` Philippe Mathieu-Daudé
2024-08-13 1:51 ` zhenwei pi
` (2 more replies)
2024-09-05 10:45 ` Markus Armbruster
1 sibling, 3 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-08-12 6:14 UTC (permalink / raw)
To: zhenwei pi, armbru; +Cc: eblake, qemu-devel, arei.gonglei
On 12/8/24 03:42, zhenwei pi wrote:
> QCryptodevBackendServiceType was introduced by
> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
> is a lack of member description. Thanks to Markus for pointing out
> this.
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> qapi/cryptodev.json | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
> index 68289f4984..9622c6d92b 100644
> --- a/qapi/cryptodev.json
> +++ b/qapi/cryptodev.json
> @@ -28,6 +28,16 @@
> #
> # The supported service types of a crypto device.
> #
> +# @cipher: Symmetric Key Cipher service
> +#
> +# @hash: Hash service
> +#
> +# @mac: Message Authentication Codes service
> +#
> +# @aead: Authenticated Encryption with Associated Data service
> +#
> +# @akcipher: Asymmetric Key Cipher service
Can we drop all trailing "service"s?
> +#
> # Since: 8.0
> ##
> { 'enum': 'QCryptodevBackendServiceType',
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Re: [PATCH] qapi: Document QCryptodevBackendServiceType
2024-08-12 6:14 ` Philippe Mathieu-Daudé
@ 2024-08-13 1:51 ` zhenwei pi
[not found] ` <a846ac05-85bd-4d6b-a86a-e9e3d4e9bc3f@bytedance.com>
2024-09-05 10:46 ` Markus Armbruster
2 siblings, 0 replies; 7+ messages in thread
From: zhenwei pi @ 2024-08-13 1:51 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, armbru; +Cc: eblake, qemu-devel, arei.gonglei
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
On 8/12/24 14:14, Philippe Mathieu-Daudé wrote:
> On 12/8/24 03:42, zhenwei pi wrote:
>> QCryptodevBackendServiceType was introduced by
>> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
>> is a lack of member description. Thanks to Markus for pointing out
>> this.
>>
>> Signed-off-by: zhenwei pi
>> ---
>> qapi/cryptodev.json | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
>> index 68289f4984..9622c6d92b 100644
>> --- a/qapi/cryptodev.json
>> +++ b/qapi/cryptodev.json
>> @@ -28,6 +28,16 @@
>> #
>> # The supported service types of a crypto device.
>> #
>> +# @cipher: Symmetric Key Cipher service
>> +#
>> +# @hash: Hash service
>> +#
>> +# @mac: Message Authentication Codes service
>> +#
>> +# @aead: Authenticated Encryption with Associated Data service
>> +#
>> +# @akcipher: Asymmetric Key Cipher service
>
> Can we drop all trailing "service"s?
>
I copied these descriptions from virtio-crypto spec. Removing them also
is fine to me.
>> +#
>> # Since: 8.0
>> ##
>> { 'enum': 'QCryptodevBackendServiceType',
>
--
zhenwei pi
[-- Attachment #2: Type: text/html, Size: 1596 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <a846ac05-85bd-4d6b-a86a-e9e3d4e9bc3f@bytedance.com>]
* PING: [PATCH] qapi: Document QCryptodevBackendServiceType
[not found] ` <a846ac05-85bd-4d6b-a86a-e9e3d4e9bc3f@bytedance.com>
@ 2024-08-20 3:46 ` zhenwei pi
0 siblings, 0 replies; 7+ messages in thread
From: zhenwei pi @ 2024-08-20 3:46 UTC (permalink / raw)
To: armbru; +Cc: eblake, qemu-devel, arei.gonglei, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
Hi Markus,
This seems to be ignored...
On 8/13/24 09:51, zhenwei pi wrote:
> On 8/12/24 14:14, Philippe Mathieu-Daudé wrote:
>> On 12/8/24 03:42, zhenwei pi wrote:
>>> QCryptodevBackendServiceType was introduced by
>>> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
>>> is a lack of member description. Thanks to Markus for pointing out
>>> this.
>>>
>>> Signed-off-by: zhenwei pi
>>> ---
>>> qapi/cryptodev.json | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
>>> index 68289f4984..9622c6d92b 100644
>>> --- a/qapi/cryptodev.json
>>> +++ b/qapi/cryptodev.json
>>> @@ -28,6 +28,16 @@
>>> #
>>> # The supported service types of a crypto device.
>>> #
>>> +# @cipher: Symmetric Key Cipher service
>>> +#
>>> +# @hash: Hash service
>>> +#
>>> +# @mac: Message Authentication Codes service
>>> +#
>>> +# @aead: Authenticated Encryption with Associated Data service
>>> +#
>>> +# @akcipher: Asymmetric Key Cipher service
>>
>> Can we drop all trailing "service"s?
>>
>
> I copied these descriptions from virtio-crypto spec. Removing them also
> is fine to me.
>
>>> +#
>>> # Since: 8.0
>>> ##
>>> { 'enum': 'QCryptodevBackendServiceType',
>>
>
> --
> zhenwei pi
>
--
zhenwei pi
[-- Attachment #2: Type: text/html, Size: 1904 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] qapi: Document QCryptodevBackendServiceType
2024-08-12 6:14 ` Philippe Mathieu-Daudé
2024-08-13 1:51 ` zhenwei pi
[not found] ` <a846ac05-85bd-4d6b-a86a-e9e3d4e9bc3f@bytedance.com>
@ 2024-09-05 10:46 ` Markus Armbruster
2024-09-05 10:56 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2024-09-05 10:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: zhenwei pi, eblake, qemu-devel, arei.gonglei
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 12/8/24 03:42, zhenwei pi wrote:
>> QCryptodevBackendServiceType was introduced by
>> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
>> is a lack of member description. Thanks to Markus for pointing out
>> this.
>> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
>> ---
>> qapi/cryptodev.json | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
>> index 68289f4984..9622c6d92b 100644
>> --- a/qapi/cryptodev.json
>> +++ b/qapi/cryptodev.json
>> @@ -28,6 +28,16 @@
>> #
>> # The supported service types of a crypto device.
>> #
>> +# @cipher: Symmetric Key Cipher service
>> +#
>> +# @hash: Hash service
>> +#
>> +# @mac: Message Authentication Codes service
>> +#
>> +# @aead: Authenticated Encryption with Associated Data service
>> +#
>> +# @akcipher: Asymmetric Key Cipher service
>
> Can we drop all trailing "service"s?
No opinion myself. Eric, what do you think?
>> +#
>> # Since: 8.0
>> ##
>> { 'enum': 'QCryptodevBackendServiceType',
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qapi: Document QCryptodevBackendServiceType
2024-09-05 10:46 ` Markus Armbruster
@ 2024-09-05 10:56 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-09-05 10:56 UTC (permalink / raw)
To: Markus Armbruster; +Cc: zhenwei pi, eblake, qemu-devel, arei.gonglei
On 5/9/24 12:46, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
>> On 12/8/24 03:42, zhenwei pi wrote:
>>> QCryptodevBackendServiceType was introduced by
>>> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
>>> is a lack of member description. Thanks to Markus for pointing out
>>> this.
>>> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
>>> ---
>>> qapi/cryptodev.json | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
>>> index 68289f4984..9622c6d92b 100644
>>> --- a/qapi/cryptodev.json
>>> +++ b/qapi/cryptodev.json
>>> @@ -28,6 +28,16 @@
>>> #
>>> # The supported service types of a crypto device.
>>> #
>>> +# @cipher: Symmetric Key Cipher service
>>> +#
>>> +# @hash: Hash service
>>> +#
>>> +# @mac: Message Authentication Codes service
>>> +#
>>> +# @aead: Authenticated Encryption with Associated Data service
>>> +#
>>> +# @akcipher: Asymmetric Key Cipher service
>>
>> Can we drop all trailing "service"s?
>
> No opinion myself. Eric, what do you think?
Not really giving any useful value, noise, but
I don't mind, no need to bike shed on this ;)
>
>>> +#
>>> # Since: 8.0
>>> ##
>>> { 'enum': 'QCryptodevBackendServiceType',
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] qapi: Document QCryptodevBackendServiceType
2024-08-12 1:42 [PATCH] qapi: Document QCryptodevBackendServiceType zhenwei pi
2024-08-12 6:14 ` Philippe Mathieu-Daudé
@ 2024-09-05 10:45 ` Markus Armbruster
1 sibling, 0 replies; 7+ messages in thread
From: Markus Armbruster @ 2024-09-05 10:45 UTC (permalink / raw)
To: zhenwei pi; +Cc: eblake, qemu-devel, arei.gonglei
zhenwei pi <pizhenwei@bytedance.com> writes:
> QCryptodevBackendServiceType was introduced by
> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
> is a lack of member description. Thanks to Markus for pointing out
> this.
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> qapi/cryptodev.json | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
> index 68289f4984..9622c6d92b 100644
> --- a/qapi/cryptodev.json
> +++ b/qapi/cryptodev.json
> @@ -28,6 +28,16 @@
> #
> # The supported service types of a crypto device.
> #
> +# @cipher: Symmetric Key Cipher service
> +#
> +# @hash: Hash service
> +#
> +# @mac: Message Authentication Codes service
> +#
> +# @aead: Authenticated Encryption with Associated Data service
> +#
> +# @akcipher: Asymmetric Key Cipher service
> +#
> # Since: 8.0
> ##
> { 'enum': 'QCryptodevBackendServiceType',
Missing: removal of QCryptodevBackendServiceType from pragma
documentation-exceptions. Happy to do that in my tree.
Apart from that
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-09-05 10:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-12 1:42 [PATCH] qapi: Document QCryptodevBackendServiceType zhenwei pi
2024-08-12 6:14 ` Philippe Mathieu-Daudé
2024-08-13 1:51 ` zhenwei pi
[not found] ` <a846ac05-85bd-4d6b-a86a-e9e3d4e9bc3f@bytedance.com>
2024-08-20 3:46 ` PING: " zhenwei pi
2024-09-05 10:46 ` Markus Armbruster
2024-09-05 10:56 ` Philippe Mathieu-Daudé
2024-09-05 10:45 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).