From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 770B1C4332F for ; Mon, 19 Dec 2022 22:06:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7OGU-0006Es-Fb; Mon, 19 Dec 2022 17:05:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7OGS-0006DR-Rd; Mon, 19 Dec 2022 17:05:40 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7OGR-0003Sc-5j; Mon, 19 Dec 2022 17:05:40 -0500 Received: by mail-ed1-x52a.google.com with SMTP id r26so14914650edc.10; Mon, 19 Dec 2022 14:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ycDw7OhDWV0wenYQxl5/LZUes6DN6MZeWTtGfKFGve0=; b=JjdNmrKKHrLTF5i5Etny0A46Bc3564yP4S6xwUfWX9bnn/nMsBw3ZIqPr/CJNWZOqu xCBhOJKsn5RRowRu51vayaQfuOobhA10IDnVvR4a0R2Tad4F2/9nZ5fPF2dRrT7SfqM3 2AFQZKlz/KD1EV5E00Efyv2DJMbjXfEkzR7T0dtewVnhNmom12WGmArCsy38imOT4JBI ixH7Fk2+iWBmSwy7rtOH4nA4jEdTZSMgo4wUaGeO2EDPDyhkVVqXVFh4Vb79/QvFPy/Y TFWR/FcUOT0jRQEL8omwi88H5PAE2RBlUnZzDL9OZmlfIOK+mqzaqnvna3Kc5xQ25Y4m tXSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ycDw7OhDWV0wenYQxl5/LZUes6DN6MZeWTtGfKFGve0=; b=hOOyGWyDen9cVzrDWy/sovP0QuC0hT0XHpP8OXw/CDJwgQZK+wOr1X8FF3NZq9KoEE kxcQiBzi29a9G8ntnxYIiIRwG6OUyLcba0jX4CGFYqfnbsDkla5oKQ0+QAxamj8DRca3 k8PQWkPrlyqwr6FnzYDeyxyM+9AV3na/H5oaPVAm+pOMXVX0mpDKMVL3zxPgrKlSY0vB EFGKVcX70h8XyRkdxKcQOyoHDRPhHzAkBD+I5IA2PEbtx3UPOkCIFqVJhwi+qYjbEuDU DB5rteq84deMfI9qxSa05gSZ3ZfUgJUvCwiCBleOdIQke/R/zo/vQ0DmR0ajqNIXbxL2 Gn+A== X-Gm-Message-State: ANoB5pmaBPTALAOFtM3NfPjewj+ypu/a3R7PYjlkZJqMgfZxuAKQFmkx hS9HkztBW3Xkpb17qW8vOmQ4Zllio5k460jgMVkj3z/+oHq4fA== X-Google-Smtp-Source: AA0mqf6xvuYk+BHMJEv2IB1wF/okohkijRPKPgrrpF8ApiGdopqy6824+YoWIJSJQTGi/h+Oo08OGoH1aAd/oxHIO6k= X-Received: by 2002:aa7:d85a:0:b0:46b:81a8:1ff6 with SMTP id f26-20020aa7d85a000000b0046b81a81ff6mr41745541eds.174.1671487537164; Mon, 19 Dec 2022 14:05:37 -0800 (PST) MIME-Version: 1.0 References: <20221218211918.3592-1-strahinja.p.jankovic@gmail.com> <20221218211918.3592-5-strahinja.p.jankovic@gmail.com> <145bf162-f53b-cf46-baf3-11e7d8ff2d8c@linaro.org> In-Reply-To: <145bf162-f53b-cf46-baf3-11e7d8ff2d8c@linaro.org> From: Strahinja Jankovic Date: Mon, 19 Dec 2022 23:05:25 +0100 Message-ID: Subject: Re: [PATCH v2 4/7] hw/misc: Allwinner AXP-209 Emulation To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Peter Maydell , Beniamino Galvani , Niek Linnenbank , qemu-arm@nongnu.org, qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=strahinjapjankovic@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Dec 19, 2022 at 8:15 AM Philippe Mathieu-Daud=C3=A9 wrote: > > On 18/12/22 23:39, Strahinja Jankovic wrote: > > Hi, > > > > On Sun, Dec 18, 2022 at 11:23 PM Philippe Mathieu-Daud=C3=A9 > > wrote: > >> > >> On 18/12/22 23:12, Strahinja Jankovic wrote: > >>> Hi, > >>> > >>> On Sun, Dec 18, 2022 at 11:07 PM Philippe Mathieu-Daud=C3=A9 > >>> wrote: > >>>> > >>>> On 18/12/22 22:19, Strahinja Jankovic wrote: > >>>>> This patch adds minimal support for AXP-209 PMU. > >>>>> Most important is chip ID since U-Boot SPL expects version 0x1. Bes= ides > >>>>> the chip ID register, reset values for two more registers used by A= 10 > >>>>> U-Boot SPL are covered. > >>>>> > >>>>> Signed-off-by: Strahinja Jankovic > >>>>> --- > >>>>> hw/arm/Kconfig | 1 + > >>>>> hw/misc/Kconfig | 4 + > >>>>> hw/misc/allwinner-axp-209.c | 238 +++++++++++++++++++++++++++++= +++++++ > >>>>> hw/misc/meson.build | 1 + > >>>>> hw/misc/trace-events | 5 + > >>>>> 5 files changed, 249 insertions(+) > >>>>> create mode 100644 hw/misc/allwinner-axp-209.c > > > >>>>> +config ALLWINNER_AXP_209 > >>>> > >>>> This controller is not specific to AllWinner. It can be plugged on a= ny > >>>> i2c bus. Please rename it AXP209_PMU. Otherwise LGTM! > >>> > >>> Do you mean only in Kconfig, or everywhere (file name, function names= , > >>> etc.)? Thanks. > >> > >> Keeping the file / functions names with 'allwinner' would give the fal= se > >> idea this is AllWinner specific; rather confusing isn't it? Besides it > >> is not part of the SoC, this is an external component sitting on the > >> bus. So "everywhere". > > > > I was expecting that answer, but I wanted to check :) > > When I started writing code for AXP209 it was indeed without allwinner > > prefix, but then checkpatch.pl complained about missing lines in > > MAINTAINERS. At that time it was easier to add the prefix (and get a > > match in MAINTAINERS) than to investigate if I should update the > > MAINTAINERS file or ignore the checkpatch.pl complaint. > > > > I will update everything related to AXP209 so it does not have the > > Allwinner prefix. > > Add a new AXP209 MAINTAINERS's section with your name :) Or add the new > file to the Allwinner-a10 section and add your name as designated > reviewer or co-maintainer :) Thanks, I will take one of these suggested approaches. Best regards, Strahinja