From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28B56C4332F for ; Sun, 18 Dec 2022 22:40:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p72Jz-0007Zu-Ru; Sun, 18 Dec 2022 17:39:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p72Jy-0007ZQ-AW; Sun, 18 Dec 2022 17:39:50 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p72Jw-0000In-La; Sun, 18 Dec 2022 17:39:50 -0500 Received: by mail-ed1-x529.google.com with SMTP id c66so10644142edf.5; Sun, 18 Dec 2022 14:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tPEAg52y9rpZLUJ3oxysKXbGG/4TGi9RDrzrY00Dbg8=; b=X8RsYnwxmOAMdezsyymkKP42cGaH7Cod4eXWCV80tufKYhjuXb7KNEXEUcyOSLzgeP JrTuwLLhKNe6rQLSmEN8QmJYuVGbf73OrHPslkaaB8hr1RLp6b7U3izcVDh7rTdyRvlO cESb6pEj53kB7iYfZltXFoF+/S/w1hljlyOBX+BdjSfUUJt12VkC8YU1cBZwNtvmxlvN 63FKsDMY7/OdfJVJI2xuC73xsY2iZWhtMrUWD58vz3XqAorDrryTs/mg70Xl1kx4HecO N5PETzleJIv94Ydts8VKLAJ6ioE/kNr7h+H1hZ8AIwjbIoT24S8gEklv1XtuNs2zy+WK KNxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tPEAg52y9rpZLUJ3oxysKXbGG/4TGi9RDrzrY00Dbg8=; b=VrhQlSqA1Gb3mpPotVRFz17sRStmLHQmj4Hr1pCZanPkiz26kM63AkejV/tPDTWJ4D /tBpXR2oY4IDDLb8zk8TmBCAFpImsqVdXOkeoBts7+ijlzvN05CKO2qmacsmqmc5vT9S 5LsYildHZv/jmRlInR6UYhRvWe927voGCr6BEL1DGf9RpRK0Yj0rLi4wOlhio1M12KTR RGaVHG1oie0MO5jyXyYMRrtJ7o9xehd+8bILcKyAJLoOo7lAqhesRs/BdGf2DC2whAgK B0B/0aK7hnmeuJnNRXY2NW1w4IirDKqdch+iliUwFs/WwygI/H7EtyEvAGxyRwohloij EMeA== X-Gm-Message-State: ANoB5pnOV5zY+dH39fGEBBYV76CxwrhiKS892sVTQNu9iKHyPHAkttKn scQulVYCDxDbHZOTFwBun5bWH85QuSz/M/EX72A= X-Google-Smtp-Source: AA0mqf6a5EUog4KVDmRKrgMfCax5vdorJDUAlnMpFJBsMn9TiTuE5BO9stqOj6FXVyACRaBhDbLUTTiWXqBYOi9x714= X-Received: by 2002:aa7:dd45:0:b0:45a:3c66:b0e4 with SMTP id o5-20020aa7dd45000000b0045a3c66b0e4mr89917435edw.33.1671403186762; Sun, 18 Dec 2022 14:39:46 -0800 (PST) MIME-Version: 1.0 References: <20221218211918.3592-1-strahinja.p.jankovic@gmail.com> <20221218211918.3592-5-strahinja.p.jankovic@gmail.com> In-Reply-To: From: Strahinja Jankovic Date: Sun, 18 Dec 2022 23:39:35 +0100 Message-ID: Subject: Re: [PATCH v2 4/7] hw/misc: Allwinner AXP-209 Emulation To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Peter Maydell , Beniamino Galvani , Niek Linnenbank , qemu-arm@nongnu.org, qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=strahinjapjankovic@gmail.com; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On Sun, Dec 18, 2022 at 11:23 PM Philippe Mathieu-Daud=C3=A9 wrote: > > On 18/12/22 23:12, Strahinja Jankovic wrote: > > Hi, > > > > On Sun, Dec 18, 2022 at 11:07 PM Philippe Mathieu-Daud=C3=A9 > > wrote: > >> > >> On 18/12/22 22:19, Strahinja Jankovic wrote: > >>> This patch adds minimal support for AXP-209 PMU. > >>> Most important is chip ID since U-Boot SPL expects version 0x1. Besid= es > >>> the chip ID register, reset values for two more registers used by A10 > >>> U-Boot SPL are covered. > >>> > >>> Signed-off-by: Strahinja Jankovic > >>> --- > >>> hw/arm/Kconfig | 1 + > >>> hw/misc/Kconfig | 4 + > >>> hw/misc/allwinner-axp-209.c | 238 ++++++++++++++++++++++++++++++++= ++++ > >>> hw/misc/meson.build | 1 + > >>> hw/misc/trace-events | 5 + > >>> 5 files changed, 249 insertions(+) > >>> create mode 100644 hw/misc/allwinner-axp-209.c > >> > >> > >>> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig > >>> index 052fb54310..3855d937fd 100644 > >>> --- a/hw/misc/Kconfig > >>> +++ b/hw/misc/Kconfig > >>> @@ -180,4 +180,8 @@ config ALLWINNER_A10_CCM > >>> config ALLWINNER_A10_DRAMC > >>> bool > >>> > >>> +config ALLWINNER_AXP_209 > >> > >> This controller is not specific to AllWinner. It can be plugged on any > >> i2c bus. Please rename it AXP209_PMU. Otherwise LGTM! > > > > Do you mean only in Kconfig, or everywhere (file name, function names, > > etc.)? Thanks. > > Keeping the file / functions names with 'allwinner' would give the false > idea this is AllWinner specific; rather confusing isn't it? Besides it > is not part of the SoC, this is an external component sitting on the > bus. So "everywhere". I was expecting that answer, but I wanted to check :) When I started writing code for AXP209 it was indeed without allwinner prefix, but then checkpatch.pl complained about missing lines in MAINTAINERS. At that time it was easier to add the prefix (and get a match in MAINTAINERS) than to investigate if I should update the MAINTAINERS file or ignore the checkpatch.pl complaint. I will update everything related to AXP209 so it does not have the Allwinner prefix. > > Also, the "select ALLWINNER_AXP_209/AXP209_PMU" line in hw/arm/Kconfig > belongs to the next patch "hw/arm: Add AXP-209 to Cubieboard". I agree, will fix it. Best regards, Strahinja > > Regards, > > Phil.