qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Santos <casantos@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH V2] tracing: install trace events file only if necessary
Date: Sat, 8 Apr 2023 06:21:59 -0300	[thread overview]
Message-ID: <CAC1VKkOn-DowAnszwzV_aRgsNQUYTOSwHti1ADAm0oyr8VNSXQ@mail.gmail.com> (raw)
In-Reply-To: <ZCHZjfytWZ6pPzpk@redhat.com>

On Mon, Mar 27, 2023 at 2:59 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote:
> > From: Carlos Santos <casantos@redhat.com>
> >
> > It is not useful when configuring with --enable-trace-backends=nop.
> >
> > Signed-off-by: Carlos Santos <casantos@redhat.com>
> > ---
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>

I updated the patch to fix the array comparison and add a missing comma.

-- 
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
casantos@redhat.com    T: +55-11-3534-6186



      reply	other threads:[~2023-04-08  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 17:30 [PATCH V2] tracing: install trace events file only if necessary casantos
2023-03-27 17:59 ` Daniel P. Berrangé
2023-04-08  9:21   ` Carlos Santos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC1VKkOn-DowAnszwzV_aRgsNQUYTOSwHti1ADAm0oyr8VNSXQ@mail.gmail.com \
    --to=casantos@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).