From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ashijeetacharya@gmail.com>) id 1bXAe6-0007Nz-Q4
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 13:16:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ashijeetacharya@gmail.com>) id 1bXAe4-0007xa-V6
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 13:16:53 -0400
Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]:34513)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ashijeetacharya@gmail.com>) id 1bXAe4-0007x8-R9
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 13:16:52 -0400
Received: by mail-oi0-x22d.google.com with SMTP id l203so26410611oib.1
	for <qemu-devel@nongnu.org>; Tue, 09 Aug 2016 10:16:52 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAC2QTZaeboA=HZ49irTjCfcYAjp80JiaTX3E=mOd8WZ3scADdA@mail.gmail.com>
References: <CAC2QTZaeboA=HZ49irTjCfcYAjp80JiaTX3E=mOd8WZ3scADdA@mail.gmail.com>
From: Ashijeet Acharya <ashijeetacharya@gmail.com>
Date: Tue, 9 Aug 2016 22:46:51 +0530
Message-ID: <CAC2QTZZM0vcm48tCfvosH+kFuscV7UMVMNDyzkEMvF5dm+2shg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] Dangling change state handler while hot unplugging
 ahci adapter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>, jsnow@redhat.com

Hi again,
I am still waiting for some guidance...Can I please get some help with this?

Also.. I tried hotplugging an AHCI adapter but got the following error:
Bus 'ahci.0' does not support hotplugging

Steps I followed:

1. launch vm with ahci enabled
2. (qemu) drive_add 0 file=test.qcow2,cache=none,if=none,id=disk2,format=qcow2
OK
3. (qemu) device_add ide-hd,bus=ahci.0,id=ahci-disk,drive=disk2
Bus 'ahci.0' does not support hotplugging

What am I doing wrong?

Thanks
Ashijeet

On Sat, Aug 6, 2016 at 11:21 PM, Ashijeet Acharya
<ashijeetacharya@gmail.com> wrote:
> Hi,
>
> I was working on a patch regarding a device lifecycle bitesize task
> and I wanted to clear my queries about what the task is exactly.
>
> Do I need to create a new function ahci_unrealize() in the
> hw/ide/ahci.c file which calls for qemu_del_vm_change_state_handler()
> to free the handler at the time of ahci hot unplug.
>
> Please tell me if I am on the right path and correct me if I am wrong.
>
> Thanks
> Ashijeet