From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98CDEC25B10 for ; Fri, 10 May 2024 07:10:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5KNa-0000dL-4E; Fri, 10 May 2024 03:09:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5KNW-0000dA-Qc for qemu-devel@nongnu.org; Fri, 10 May 2024 03:09:14 -0400 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5KNQ-0000bQ-UJ for qemu-devel@nongnu.org; Fri, 10 May 2024 03:09:14 -0400 Received: by mail-ua1-x92d.google.com with SMTP id a1e0cc1a2514c-7f82c932858so564613241.0 for ; Fri, 10 May 2024 00:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715324945; x=1715929745; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=05e6kfPELjdIiB5komuWQQEzsIOEGVInSuH1WtN+4KA=; b=JJZ9g+3lLJXkT7GhbPHrZnfexGIxVJIWnAmGnYb6erZpEZvDG1MRRjv3e/uLeREKoc e51TNM9YrpPYpSYsiB/Btmk5MeXcCjBmt0vAMv30RfcSsIqm9qZ8jUExIkFtTknGpG+f cLWHML9LAX8Z7uY2CC717GbZEYD6JjjMu7OqDHaG5s3uhN4a6eFarIqZkxVueVDPM+yh qjCGDmZPRzyIqFcBJ9jb1PGlPrakzHfl82bVlYJN8xtrRFEJNiC2k3bQYfcF7htPbrVz OibLtkvbAm1Qgi9xpY69JjYhKWy9TVs7oOmvCgd0ycSfvDACwSq604FzuhXR15MzMNpK w/yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715324945; x=1715929745; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=05e6kfPELjdIiB5komuWQQEzsIOEGVInSuH1WtN+4KA=; b=iVyQ+ffaU2u7/deazP79DEvAoDtQlk962RisiIJZmq1lGMSVwlV7pcZ5pADRk7jRC6 aDoWqk3omB2kwaWldVrEasoMDp5NJe4tfquib5eFMsoAz/4m8tkzXgLFChhFP5nU3uU3 gA0yQYkQeLx9ivtX8owMJK0JQLvIYD882i8CbPmBRdmY6Fn1wEIQjvIvwo3kf/iz7VLj 2hkqJBN54SlcY3XM1lTydF9wl6SSYO0dXyrOZqGOtIFPY+Oj98BxD7/k4CokMR/uuku2 yLYMAo2pFS1xecxH66Y93ISjFp1h2O8t6gUEZhLq0uE7fgLlc78ZWBEyJUP+7gwAx/ZP oymQ== X-Forwarded-Encrypted: i=1; AJvYcCWj8t7hCHxgXjErb4RUvpoI/QXU+5a9pQcqsYe5QrZegoGDsFldduJ88r5sWWvbBIPObU6M0eNlZpf/TMB3W1ocRqAogU8= X-Gm-Message-State: AOJu0YxZs6Onl8K5sJ6zsZEeRdHw1QaSDXs8HM2Qtc3+DFqEDIQHbFIY 5SKemt60B/Uh2hawoWwcpzX6I8415Vh/2D+9oE5PsBTDNJitka8YkELds73fGfLqxcH3YZP+V/K u9a97XGnfba4TuZ6i/9IEFItT3xY= X-Google-Smtp-Source: AGHT+IFf3hfiFfH2oE67tBkY8UXKV8VN+jilJ+ZwWC4KSCWT0zm4s8nLVRf1shMe2DDxHXQQprTdco6/xC9JjazhNos= X-Received: by 2002:a05:6102:570d:b0:47c:23b7:f50d with SMTP id ada2fe7eead31-48077e5d79cmr1742100137.35.1715324945247; Fri, 10 May 2024 00:09:05 -0700 (PDT) MIME-Version: 1.0 References: <8dadea4d-ab16-4102-93e6-61559fb5b00c@linaro.org> <6fab2d56-84c4-15fa-bcaf-b08f2c8210aa@eik.bme.hu> In-Reply-To: <6fab2d56-84c4-15fa-bcaf-b08f2c8210aa@eik.bme.hu> From: Cord Amfmgm Date: Fri, 10 May 2024 02:08:54 -0500 Message-ID: Subject: Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT To: BALATON Zoltan Cc: Peter Maydell , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Michael Tokarev , qemu-devel@nongnu.org, Gerd Hoffmann Content-Type: multipart/alternative; boundary="0000000000000934f806181436c2" Received-SPF: pass client-ip=2607:f8b0:4864:20::92d; envelope-from=dmamfmgm@gmail.com; helo=mail-ua1-x92d.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --0000000000000934f806181436c2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 9, 2024 at 3:37=E2=80=AFPM BALATON Zoltan = wrote: > On Thu, 9 May 2024, Cord Amfmgm wrote: > > On Thu, May 9, 2024 at 12:48=E2=80=AFPM Peter Maydell > > wrote: > > > >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > >>> On Wed, May 8, 2024 at 3:45=E2=80=AFAM Thomas Huth = wrote: > >>>> > >>>> Your Signed-off-by line does not match the From: line ... could you > >> please > >>>> fix this? (see > >>>> > >> > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emai= ls-must-include-a-signed-off-by-line > >>>> , too) > >>> > >>> > >>> I'll submit the new patch request with my pseudonym in the From: and > >> Signed-off-by: lines, per your request. Doesn't matter to me. However, > this > >> arises simply because I don't give gmail my real name - > >> https://en.wikipedia.org/wiki/Nymwars > >> > >> I'm confused now. Of the two names you've used in this > >> patch (Cord Amfmgm and David Hubbard), are they both > >> pseudonyms, or is one a pseudonym and one your real name? > >> > >> > > Hi Peter, > > > > I am attempting to submit a small patch. For context, I'm getting broad= er > > attention now because apparently OHCI is one of the less used component= s > of > > qemu and maybe the review process was taking a while. That's relevant > > because I wasn't able to get prompt feedback and am now choosing what > > appears to be the most expeditious approach -- all I want is to get thi= s > > patch done and be out of your hair. If Thomas Huth wants me to use a > > consistent name, have I not complied? Are you asking out of curiosity o= r > is > > there a valid reason why I should answer your question in order to get > the > > patch submitted? Would you like to have a friendly chat over virtual > coffee > > sometime (but off-list)? > > See here: > > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emai= ls-must-include-a-signed-off-by-line > and also the document linked from there: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Docum= entation/SubmittingPatches?id=3Df6f94e2ab1b33f0082ac22d71f66385a60d8157f#n2= 97 Yeah the policy makes sense. So it sounds like we're all good for that. > > > As for getting the patch reviewed, it may be difficult as the USB > maintainer is practically absent and has no time for QEMU for a while and > as OHCI as you said is not odten used there aren't many people who could > review it. Getting at least the formal stuff out of the way may help > though to get somebody to try to review the patch. > > Regards, > BALATON Zoltan I understand. Well, that's unfortunate that the patch is going back on the backlog. I'll leave it alone then? There's always the option if anyone has an old enough system that the EHCI on it has an actual OHCI companion controller, then they can use actual hardware to validate the behavior. Barring some message saying the patch has been approved or that someone wants me to rework the patch, I'll leave this as abandoned. --0000000000000934f806181436c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, May 9, 2024 at 3:37=E2=80=AFP= M BALATON Zoltan <balaton@eik.bme.= hu> wrote:
peter.maydell@linaro.org<= /a>>
> wrote:
>
>> On Wed, 8 May 2024 at 16:29, Cord Amfmgm <dmamfmgm@gmail.com> wrote:
>>> On Wed, May 8, 2024 at 3:45=E2=80=AFAM Thomas Huth <thuth@redhat.com> wro= te:
>>>>
>>>> Your Signed-off-by line does not match the From: line ... = could you
>> please
>>>> fix this? (see
>>>>
>> https://www.qemu.org/docs/master/devel/submitting-a-patch= .html#patch-emails-must-include-a-signed-off-by-line
>>>> , too)
>>>
>>>
>>> I'll submit the new patch request with my pseudonym in the= From: and
>> Signed-off-by: lines, per your request. Doesn't matter to me. = However, this
>> arises simply because I don't give gmail my real name -
>> https://en.wikipedia.org/wiki/Nymwars
>>
>> I'm confused now. Of the two names you've used in this
>> patch (Cord Amfmgm and David Hubbard), are they both
>> pseudonyms, or is one a pseudonym and one your real name?
>>
>>
> Hi Peter,
>
> I am attempting to submit a small patch. For context, I'm getting = broader
> attention now because apparently OHCI is one of the less used componen= ts of
> qemu and maybe the review process was taking a while. That's relev= ant
> because I wasn't able to get prompt feedback and am now choosing w= hat
> appears to be the most expeditious approach -- all I want is to get th= is
> patch done and be out of your hair. If Thomas Huth wants me to use a > consistent name, have I not complied? Are you asking out of curiosity = or is
> there a valid reason why I should answer your question in order to get= the
> patch submitted? Would you like to have a friendly chat over virtual c= offee
> sometime (but off-list)?

See here:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#pat= ch-emails-must-include-a-signed-off-by-line
and also the document linked from there:
http://git.kernel.org/cgi= t/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?= id=3Df6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
Yeah the policy makes sense. So it sounds like we're all go= od for that.
=C2=A0


As for getting the patch reviewed, it may be difficult as the USB
maintainer is practically absent and has no time for QEMU for a while and <= br> as OHCI as you said is not odten used there aren't many people who coul= d
review it. Getting at least the formal stuff out of the way may help
though to get somebody to try to review the patch.

Regards,
BALATON Zoltan
=C2=A0
I understand. Well, th= at's unfortunate that the patch is going back on the backlog. I'll = leave it alone then?

There's always the option= if anyone has an old enough system that the EHCI on it has an actual OHCI = companion controller, then they can use actual hardware to validate the beh= avior. Barring some message saying the patch has been approved or that some= one wants=C2=A0me to rework the patch, I'll leave this as abandoned.
--0000000000000934f806181436c2--