* [PATCH] hw/net/rocker: Remove unused rocker_fp_ports
@ 2024-09-18 23:14 dave
2024-10-02 10:43 ` Thomas Huth
2024-10-09 8:32 ` Jason Wang
0 siblings, 2 replies; 3+ messages in thread
From: dave @ 2024-09-18 23:14 UTC (permalink / raw)
To: jiri, jasowang, qemu-devel; +Cc: Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <dave@treblig.org>
rocker_fp_ports hasn't been used since it was added back in 2015.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
hw/net/rocker/rocker.c | 5 -----
hw/net/rocker/rocker.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index 1ab5852113..5e74acc969 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -134,11 +134,6 @@ RockerPortList *qmp_query_rocker_ports(const char *name, Error **errp)
return list;
}
-uint32_t rocker_fp_ports(Rocker *r)
-{
- return r->fp_ports;
-}
-
static uint32_t rocker_get_pport_by_tx_ring(Rocker *r,
DescRing *ring)
{
diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
index f85354d9d1..6e0962f47a 100644
--- a/hw/net/rocker/rocker.h
+++ b/hw/net/rocker/rocker.h
@@ -72,7 +72,6 @@ DECLARE_INSTANCE_CHECKER(Rocker, ROCKER,
TYPE_ROCKER)
Rocker *rocker_find(const char *name);
-uint32_t rocker_fp_ports(Rocker *r);
int rocker_event_link_changed(Rocker *r, uint32_t pport, bool link_up);
int rocker_event_mac_vlan_seen(Rocker *r, uint32_t pport, uint8_t *addr,
uint16_t vlan_id);
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/net/rocker: Remove unused rocker_fp_ports
2024-09-18 23:14 [PATCH] hw/net/rocker: Remove unused rocker_fp_ports dave
@ 2024-10-02 10:43 ` Thomas Huth
2024-10-09 8:32 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-10-02 10:43 UTC (permalink / raw)
To: dave, jiri, jasowang, qemu-devel, QEMU Trivial
On 19/09/2024 01.14, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> rocker_fp_ports hasn't been used since it was added back in 2015.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> hw/net/rocker/rocker.c | 5 -----
> hw/net/rocker/rocker.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
> index 1ab5852113..5e74acc969 100644
> --- a/hw/net/rocker/rocker.c
> +++ b/hw/net/rocker/rocker.c
> @@ -134,11 +134,6 @@ RockerPortList *qmp_query_rocker_ports(const char *name, Error **errp)
> return list;
> }
>
> -uint32_t rocker_fp_ports(Rocker *r)
> -{
> - return r->fp_ports;
> -}
> -
> static uint32_t rocker_get_pport_by_tx_ring(Rocker *r,
> DescRing *ring)
> {
> diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
> index f85354d9d1..6e0962f47a 100644
> --- a/hw/net/rocker/rocker.h
> +++ b/hw/net/rocker/rocker.h
> @@ -72,7 +72,6 @@ DECLARE_INSTANCE_CHECKER(Rocker, ROCKER,
> TYPE_ROCKER)
>
> Rocker *rocker_find(const char *name);
> -uint32_t rocker_fp_ports(Rocker *r);
> int rocker_event_link_changed(Rocker *r, uint32_t pport, bool link_up);
> int rocker_event_mac_vlan_seen(Rocker *r, uint32_t pport, uint8_t *addr,
> uint16_t vlan_id);
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/net/rocker: Remove unused rocker_fp_ports
2024-09-18 23:14 [PATCH] hw/net/rocker: Remove unused rocker_fp_ports dave
2024-10-02 10:43 ` Thomas Huth
@ 2024-10-09 8:32 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2024-10-09 8:32 UTC (permalink / raw)
To: dave; +Cc: jiri, qemu-devel
On Thu, Sep 19, 2024 at 7:14 AM <dave@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> rocker_fp_ports hasn't been used since it was added back in 2015.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
Queued.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 23:14 [PATCH] hw/net/rocker: Remove unused rocker_fp_ports dave
2024-10-02 10:43 ` Thomas Huth
2024-10-09 8:32 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).