From: Jason Wang <jasowang@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()
Date: Tue, 26 Mar 2024 14:42:01 +0800 [thread overview]
Message-ID: <CACGkMEsETOZnWkBpq95-no4_uP8QczsutEkK-GM_79_PKwajnA@mail.gmail.com> (raw)
In-Reply-To: <20231219-glib-v1-0-1b040d286b91@daynix.com>
On Tue, Dec 19, 2023 at 7:59 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> g_spawn_sync() gives an informative message if it fails to execute
> the script instead of reporting exiting status 1.
>
> g_spawn_check_wait_status() also gives an message easier to understand
> than the raw value returned by waitpid().
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Akihiko Odaki (2):
> glib-compat: Define g_spawn_check_wait_status()
> tap: Use g_spawn_sync() and g_spawn_check_wait_status()
>
> include/glib-compat.h | 2 ++
> net/tap.c | 52 ++++++++++++++++++++++-----------------------------
> 2 files changed, 24 insertions(+), 30 deletions(-)
> ---
> base-commit: 9c74490bff6c8886a922008d0c9ce6cae70dd17e
> change-id: 20231219-glib-034a34bb05d8
>
> Best regards,
> --
> Akihiko Odaki <akihiko.odaki@daynix.com>
I've queued this for 9.1
Thanks
>
prev parent reply other threads:[~2024-03-26 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 11:58 [PATCH 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status() Akihiko Odaki
2023-12-19 11:58 ` [PATCH 1/2] glib-compat: Define g_spawn_check_wait_status() Akihiko Odaki
2023-12-19 11:58 ` [PATCH 2/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status() Akihiko Odaki
2024-03-26 6:42 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACGkMEsETOZnWkBpq95-no4_uP8QczsutEkK-GM_79_PKwajnA@mail.gmail.com \
--to=jasowang@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).