From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83321C433F5 for ; Thu, 4 Nov 2021 02:47:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04C97600D4 for ; Thu, 4 Nov 2021 02:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 04C97600D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miSmo-0000RK-QK for qemu-devel@archiver.kernel.org; Wed, 03 Nov 2021 22:47:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miSlX-00083L-AX for qemu-devel@nongnu.org; Wed, 03 Nov 2021 22:46:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27243) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miSlR-0007i4-Of for qemu-devel@nongnu.org; Wed, 03 Nov 2021 22:46:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635993964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YP/yOLmMm/sWLcuNtjBeezZwq4HiR5P1pp8C19wTJiQ=; b=iB2ZpwAg6fMs4VzUQ05QXenks/VmLSfy0Y74HVDEXz/eOaGDO3T7ELYJ5+C1jlXhlLc1fC Qut4pl1KSFftJSy9P6bHOkIT2kjKNk/1jIeNOD6sI/lruA+HTCxPcnxCZJML0TiybCnzDj nzGTHASVQHRbdJx/jH4VnEmAsBugcec= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-332-HP7mclnqPPyynwkRx2LsjA-1; Wed, 03 Nov 2021 22:46:01 -0400 X-MC-Unique: HP7mclnqPPyynwkRx2LsjA-1 Received: by mail-lf1-f71.google.com with SMTP id i1-20020a056512340100b003fdd5b951e0so1339096lfr.22 for ; Wed, 03 Nov 2021 19:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YP/yOLmMm/sWLcuNtjBeezZwq4HiR5P1pp8C19wTJiQ=; b=Hh07djP2i36IsG1rbUQN9D2ZsRKCeu6/5s0Ox60aZgnCgkyaPkRxukYfSR1/l7hiMG W5K5Q+r321VjoMBAnL4ogHBK6U2fMHJYGOuWk6gLNaoJke7Ja+UWhUo/vIkYUe5IaJnI /W6Vv+6WT0txRiKyedUq3PYRfsV9nR2K+mq1627gUTlOuseCuPSlTjHqpSTJ1I3/1mOA GqNM730CnJC6mkYUCa64vBCBcE8kNBJQxSaBvb9TWb8B1Gr1F2XLSxVh0EkVMVtw8Dcm cbaPGrl9AJdWIkHuIwTL57DwUyglSbBir3o3pdzt3cOcNJMW157gkJ0opDWUzZvs4rbr UA6w== X-Gm-Message-State: AOAM530f1imbquNvpZ/QIuBdw00V0TTPQ2g1oTIt6YLonA6AOUFUOYd0 pn5NGNU+GwUeYaHKyNA5V6/G8/8MhUCNO6AbPvdzcDzClVfqD1wgwc8qDr8OYe4VHiAUUkvA4aW UoCwdgA4iu/i3d51yxQDPXpjvL5B1G6Q= X-Received: by 2002:a2e:9155:: with SMTP id q21mr51176302ljg.217.1635993959401; Wed, 03 Nov 2021 19:45:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfV89rTEhGJqt9GpD1p4fATa1S2uVJ8VSNXBi9pcXywQqnmJpLQRtpg8bMcz89hznG4kdsGYphhQ8zFLfp10A= X-Received: by 2002:a2e:9155:: with SMTP id q21mr51176279ljg.217.1635993959152; Wed, 03 Nov 2021 19:45:59 -0700 (PDT) MIME-Version: 1.0 References: <20211103100131.1983272-1-eperezma@redhat.com> <20211103100131.1983272-2-eperezma@redhat.com> In-Reply-To: <20211103100131.1983272-2-eperezma@redhat.com> From: Jason Wang Date: Thu, 4 Nov 2021 10:45:48 +0800 Message-ID: Subject: Re: [PATCH v3 1/2] vhost: Rename last_index to last_vq_index To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-devel , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 3, 2021 at 6:01 PM Eugenio P=C3=A9rez wro= te: > > The doc of this field points out that last_index is the last vq index. > Since last_index can cause confusion if seen out of context, renaming > to last_vq_index, aligning with vq_index. > > Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang > --- > include/hw/virtio/vhost.h | 2 +- > hw/net/vhost_net.c | 4 ++-- > hw/virtio/vhost-vdpa.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h > index 3fa0b554ef..8a79833b54 100644 > --- a/include/hw/virtio/vhost.h > +++ b/include/hw/virtio/vhost.h > @@ -75,7 +75,7 @@ struct vhost_dev { > /* the first virtqueue which would be used by this vhost dev */ > int vq_index; > /* the last vq index for the virtio device (not vhost) */ > - int last_index; > + int last_vq_index; > /* if non-zero, minimum required value for max_queues */ > int num_queues; > uint64_t features; > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index 0d888f29a6..081946dc93 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -232,10 +232,10 @@ fail: > } > > static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index, > - int last_index) > + int last_vq_index) > { > net->dev.vq_index =3D vq_index; > - net->dev.last_index =3D last_index; > + net->dev.last_vq_index =3D last_vq_index; > } > > static int vhost_net_start_one(struct vhost_net *net, > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index 12661fd5b1..a1831b27ca 100644 > --- a/hw/virtio/vhost-vdpa.c > +++ b/hw/virtio/vhost-vdpa.c > @@ -632,7 +632,7 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev= , bool started) > vhost_vdpa_host_notifiers_uninit(dev, dev->nvqs); > } > > - if (dev->vq_index + dev->nvqs !=3D dev->last_index) { > + if (dev->vq_index + dev->nvqs !=3D dev->last_vq_index) { > return 0; > } > > -- > 2.27.0 >