From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9B0C433F5 for ; Mon, 15 Nov 2021 04:24:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E20C963222 for ; Mon, 15 Nov 2021 04:24:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E20C963222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmTXF-0004td-4V for qemu-devel@archiver.kernel.org; Sun, 14 Nov 2021 23:24:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmTWM-00043d-Hj for qemu-devel@nongnu.org; Sun, 14 Nov 2021 23:23:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmTWK-0004Th-In for qemu-devel@nongnu.org; Sun, 14 Nov 2021 23:23:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636950183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uIZeWQ4TDZbu8fedh6UFUZKhYT1CiOuH70tNC6lXnnA=; b=YalMgF+I1fG4I4Co86FmQbTAWgjAzbe7ul00TYjAS8BaqAhSuchcLcdTaQ3GAiWUIwUC/4 Xp52EDOwavNHI9nh++HFrk96BAbW7kiy2Eh+twdhVlzIjAVpT7Eh/q/RjUAqL0oEHoK02Q 2PfNL906GismQWlh36yYkQDojF55UMA= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-xv1Wg1pjO_a-o3ltWXYiBw-1; Sun, 14 Nov 2021 23:23:02 -0500 X-MC-Unique: xv1Wg1pjO_a-o3ltWXYiBw-1 Received: by mail-lf1-f71.google.com with SMTP id d2-20020a0565123d0200b0040370d0d2fbso6169913lfv.23 for ; Sun, 14 Nov 2021 20:23:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uIZeWQ4TDZbu8fedh6UFUZKhYT1CiOuH70tNC6lXnnA=; b=26WDYu/SZLpvxcXLwyQ8Im0gbgnGVdeGRE5s27l7TuUvUnzNrHWP5nqYOjXOSVq9QP KGkAW0PylJaohaSbz7++SXq+exRfYEOrWJCds2ordLXsSSeVy/fuSWYZ6mUoA5nFuIhj CQCnJwsUHllM7eZqGO8vXzu6NsN2rHbNd9uecCax+0Qqs8LVt1wT8bKyPxugjqjLj6fS wDIiM1INqAa2+lPqCYmrVtWIFvAITN/JJHf5RJKTqbRgmzalvEwfnCFFZP9LQp0xR6ND DAXUDsTPOjALXc7Jp+6/2ubwnR09vVimXMCmatAuOhah8ZeBoEboHPaidcOHPSwT1r9/ sEFw== X-Gm-Message-State: AOAM533aIe+zLdIKnfP054xwnPGlb4WS/0UY52V/xwo8DtXZwjD1YfUL HCPxEIe39WbcZBw4EyoZPinaR1EnhkxahXAACpeSdYh1d3tXgyMTQxbV7d6ME4ZQ7piEjlI47Yz 1aNM4oHYOxjoaaznF2qtZs3sTa6CA5N4= X-Received: by 2002:a05:6512:2081:: with SMTP id t1mr30933569lfr.348.1636950181166; Sun, 14 Nov 2021 20:23:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8eiGrx0+jITCGj3R8pu3cSlzXs6lnnhcmCTu0RrlZqfRjnt1FZTDLKERm4Rv3vZoVKgBhJx8ZgBjLmQUq5hw= X-Received: by 2002:a05:6512:2081:: with SMTP id t1mr30933539lfr.348.1636950180814; Sun, 14 Nov 2021 20:23:00 -0800 (PST) MIME-Version: 1.0 References: <20211112193431.2379298-1-eperezma@redhat.com> <20211112193431.2379298-2-eperezma@redhat.com> In-Reply-To: <20211112193431.2379298-2-eperezma@redhat.com> From: Jason Wang Date: Mon, 15 Nov 2021 12:22:49 +0800 Message-ID: Subject: Re: [PATCH 1/2] vdpa: Replace qemu_open_old by qemu_open at To: =?UTF-8?Q?Eugenio_P=C3=A9rez?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.695, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Laurent Vivier , qemu-devel , Cindy Lu , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Nov 13, 2021 at 3:34 AM Eugenio P=C3=A9rez wr= ote: > > There is no reason to keep using the old one, since we neither use the > variadics arguments nor open it with O_DIRECT. > > Also, net_client_init1, the caller of net_init_vhost_vdpa, wants all > net_client_init_fun to use Error API, so it's a good step in that > direction. > > Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang > --- > net/vhost-vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 49ab322511..6ffb29f4da 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -261,7 +261,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const c= har *name, > assert(netdev->type =3D=3D NET_CLIENT_DRIVER_VHOST_VDPA); > opts =3D &netdev->u.vhost_vdpa; > > - vdpa_device_fd =3D qemu_open_old(opts->vhostdev, O_RDWR); > + vdpa_device_fd =3D qemu_open(opts->vhostdev, O_RDWR, errp); > if (vdpa_device_fd =3D=3D -1) { > return -errno; > } > -- > 2.27.0 >