qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org
Cc: Xiao Lei <leixiao.nop@zju.edu.cn>,
	Yuri Benditovich <yuri.benditovich@daynix.com>,
	 qemu-stable@nongnu.org,
	Mauro Matteo Cascella <mcascell@redhat.com>
Subject: Re: [PATCH] virtio-net: correctly copy vnet header when flushing TX
Date: Mon, 15 Jan 2024 10:38:10 +0800	[thread overview]
Message-ID: <CACGkMEva2WJvsgLYUNTk5ZSy0PfntHWHUKUbk0K=Xj+WKOjpuw@mail.gmail.com> (raw)
In-Reply-To: <20240102032901.3234-1-jasowang@redhat.com>

On Tue, Jan 2, 2024 at 11:29 AM Jason Wang <jasowang@redhat.com> wrote:
>
> When HASH_REPORT is negotiated, the guest_hdr_len might be larger than
> the size of the mergeable rx buffer header. Using
> virtio_net_hdr_mrg_rxbuf during the header swap might lead a stack
> overflow in this case. Fixing this by using virtio_net_hdr_v1_hash
> instead.
>
> Reported-by: Xiao Lei <leixiao.nop@zju.edu.cn>
> Cc: Yuri Benditovich <yuri.benditovich@daynix.com>
> Cc: qemu-stable@nongnu.org
> Cc: Mauro Matteo Cascella <mcascell@redhat.com>
> Fixes: CVE-2023-6693
> Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report")
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Queued.

Thanks



  parent reply	other threads:[~2024-01-15  2:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02  3:29 [PATCH] virtio-net: correctly copy vnet header when flushing TX Jason Wang
2024-01-02 11:19 ` Yuri Benditovich
2024-01-02 11:25   ` Mauro Matteo Cascella
2024-01-15  2:38 ` Jason Wang [this message]
2024-01-20 10:42 ` Michael Tokarev
2024-01-22  4:20   ` Jason Wang
2024-01-21  7:35 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACGkMEva2WJvsgLYUNTk5ZSy0PfntHWHUKUbk0K=Xj+WKOjpuw@mail.gmail.com' \
    --to=jasowang@redhat.com \
    --cc=leixiao.nop@zju.edu.cn \
    --cc=mcascell@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).