From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDA1C433C1 for ; Mon, 29 Mar 2021 06:07:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D47161945 for ; Mon, 29 Mar 2021 06:07:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D47161945 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQl3H-00047N-Q2 for qemu-devel@archiver.kernel.org; Mon, 29 Mar 2021 02:07:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQl2D-0003h5-Pe for qemu-devel@nongnu.org; Mon, 29 Mar 2021 02:05:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQl2C-00049l-4o for qemu-devel@nongnu.org; Mon, 29 Mar 2021 02:05:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616997954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/8gbOuRAYG65Oqt++W5UxJl8TeM1tmNiiP/d+9e85Wc=; b=OhCLMzTtXughZVnBfMosYrF5CcV433qvBfFlsMFftZN62seGaIXHAK2ReiAW3KwMJKYJzw CjES22H+IsIiHr9wWfHIHuN8uskm5wH6zuJH1ZETBHXFxnl4CwereTvejp2Tv9rxtVfiAQ G19tOnd6fejsAAkrSa4s6Tp+JT8bT7U= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-gA5CpzH7NMmyjXXI9y1Paw-1; Mon, 29 Mar 2021 02:05:52 -0400 X-MC-Unique: gA5CpzH7NMmyjXXI9y1Paw-1 Received: by mail-pj1-f72.google.com with SMTP id dw22so10742582pjb.6 for ; Sun, 28 Mar 2021 23:05:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/8gbOuRAYG65Oqt++W5UxJl8TeM1tmNiiP/d+9e85Wc=; b=VF27PqoOUuXDLn6GlMzgu9HqejMfANaPUpHkzHqqciSe4BIPzs2Y1MLRnGdqtnMCg4 qsz/zifgBjeWzAIru9qclkbSasJoUZB631CrFJM3WdKCwaJUOg5qGG2gcD9en3ZHWsnu qNuEtaMJ+AI+KFZ1M/9AWfhiSF1DmiHLZVcZo55V/gtkiYAO020xjhmA1jXwoe5mjMYm w1e2emUArXxdgmGitpzvgngL8AfZ5g/iNv6up54fLL6dKa2YquQK1OGweg2Q3evCHM7W qAou/QiXQogytd9LcxJ9rWzf4BA59Ei7qLXQoRi6Y97p79geb04oBqcT4xid9+gjjqA0 cIjg== X-Gm-Message-State: AOAM533igsbbYlm0BPCOjcAKpat21VRp6frByp0H34JW6o+66JgKWOz2 jP0WjS/UZ30X3hOsmG/SwACZcWN5K5Fce8Qolw+aL5Qdi647yk9ZIvCQMWrkR7EJ2iO1gwXkXso 6CXpuB5JqMH60WwRcjJPX786M8gW3a0w= X-Received: by 2002:a63:3e4b:: with SMTP id l72mr1597751pga.203.1616997951541; Sun, 28 Mar 2021 23:05:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSPmOiFycSDaKIWvEohOBxDlF+x//RFDqQiOcv+ECz2XeS+XhsHO/ExT2mlSPHyhNEv7K5mPr6dfcc8z0b1G0= X-Received: by 2002:a63:3e4b:: with SMTP id l72mr1597738pga.203.1616997951290; Sun, 28 Mar 2021 23:05:51 -0700 (PDT) MIME-Version: 1.0 References: <20210323015641.10820-1-lulu@redhat.com> <20210323015641.10820-2-lulu@redhat.com> <83dac3f6-ea2f-76e3-3d2e-394483c3bc5c@redhat.com> In-Reply-To: <83dac3f6-ea2f-76e3-3d2e-394483c3bc5c@redhat.com> From: Cindy Lu Date: Mon, 29 Mar 2021 14:05:13 +0800 Message-ID: Subject: Re: [PATCH v4 1/4] virtio:add support in configure interrupt To: Jason Wang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lulu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=lulu@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Michael Tsirkin Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Mar 26, 2021 at 4:29 PM Jason Wang wrote: > > > =E5=9C=A8 2021/3/25 =E4=B8=8B=E5=8D=883:15, Cindy Lu =E5=86=99=E9=81=93: > > +enum virtio_config_status { > + VIRTIO_CONFIG_SUPPORT, > + VIRTIO_CONFIG_WORK, > + VIRTIO_CONFIG_STOP, > + VIRTIO_CONFIG_STATUS_UNKNOWN, > > Any reason for this extra state? I think we can know whether the config > interrupt is being used through a > > Thanks > > The problem is I need to split the backend devices into 3 types, > 1=EF=BC=89 normal device > 2=EF=BC=89vdpa support config interrupt. and the configur interrupt is ac= tive now > 3=EF=BC=89vdpa not support config interrupt. > So I add this bit and this bit will init in vpda /vhost modules and > qemu can check this bit to know the which behariver we will do in > virtio bus and other modules, > > > I wonder whether it's a must. We can setup guest notifiers unconditionall= y, so if it's an vhost bakcend without config interrupt support, such notif= iers won't be used. > > Thanks > sure,That make sense I will post a new version > > Maybe I need to change this bit's name > to make it more clearly > > Thanks > Cindy > > >