From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D096C433F5 for ; Sun, 5 Sep 2021 19:05:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1F6760F5B for ; Sun, 5 Sep 2021 19:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F1F6760F5B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=freebsd.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMxRq-0002q1-Gh for qemu-devel@archiver.kernel.org; Sun, 05 Sep 2021 15:04:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMxEB-0004IX-QL for qemu-devel@nongnu.org; Sun, 05 Sep 2021 14:50:51 -0400 Received: from mx2.freebsd.org ([2610:1c1:1:606c::19:2]:21718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMxE9-0004EM-9t for qemu-devel@nongnu.org; Sun, 05 Sep 2021 14:50:51 -0400 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 83AA682CBB for ; Sun, 5 Sep 2021 18:50:47 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H2gbC2wy9z3hdx for ; Sun, 5 Sep 2021 18:50:47 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4092B9B79 for ; Sun, 5 Sep 2021 18:50:47 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f175.google.com with SMTP id t4so4737987qkb.9 for ; Sun, 05 Sep 2021 11:50:47 -0700 (PDT) X-Gm-Message-State: AOAM530WhoC/u6JnP9CahFIF8RpR9YmskRmTzCWwwhbOhTRaEYDpNbaP TAnr11X7kgSzygglKZjhiwC5bRNcg2GCB20C7Do= X-Google-Smtp-Source: ABdhPJxVJcT1LdzZonPs/hUODePCINV4+mAfkl26ysnNm6kNI8UlegPBwPR/uUmCL9gimWfg6ZzF4qYN7wsLQbVomMw= X-Received: by 2002:a05:620a:2849:: with SMTP id h9mr7743018qkp.69.1630867846898; Sun, 05 Sep 2021 11:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20210902234729.76141-1-imp@bsdimp.com> <20210902234729.76141-40-imp@bsdimp.com> In-Reply-To: <20210902234729.76141-40-imp@bsdimp.com> From: Kyle Evans Date: Sun, 5 Sep 2021 13:50:35 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 39/43] bsd-user: Refactor load_elf_sections and is_target_elf_binary To: Warner Losh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2610:1c1:1:606c::19:2; envelope-from=kevans@freebsd.org; helo=mx2.freebsd.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kyle Evans , Warner Losh , QEMU Developers , =?UTF-8?Q?Mika=C3=ABl_Urankar?= , Stacey Son Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 2, 2021 at 6:56 PM wrote: > > From: Warner Losh > > Factor out load_elf_sections and is_target_elf_binary out of > load_elf_interp. > > Signed-off-by: Mika=C3=ABl Urankar > Signed-off-by: Stacey Son > Signed-off-by: Warner Losh > --- > bsd-user/elfload.c | 344 +++++++++++++++++++++------------------------ > 1 file changed, 158 insertions(+), 186 deletions(-) > Reviewed-by: Kyle Evans