From: Joel Stanley <joel@jms.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-5.2 19/19] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller
Date: Fri, 7 Aug 2020 00:12:27 +0000 [thread overview]
Message-ID: <CACPK8Xc4uGR5OAX=TNmjDdHD7i2mzEkhJVty8tn-Z=g6spBgGw@mail.gmail.com> (raw)
In-Reply-To: <20200806132106.747414-20-clg@kaod.org>
On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater <clg@kaod.org> wrote:
>
> This change works around the HW default values to be able to test the
> tacoma board with -kernel command line option.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Good fix. This was required for Tacoma when we had both flash chips
enabled in the device tree, otherwise Linux would fail to probe the
entire controller leaving it with no rootfs.
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> hw/ssi/aspeed_smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
> index 8c79a5552f93..795784e5f364 100644
> --- a/hw/ssi/aspeed_smc.c
> +++ b/hw/ssi/aspeed_smc.c
> @@ -230,7 +230,7 @@ static void aspeed_smc_reg_to_segment(const AspeedSMCState *s, uint32_t reg,
>
> static const AspeedSegments aspeed_segments_ast2600_fmc[] = {
> { 0x0, 128 * MiB }, /* start address is readonly */
> - { 0x0, 0 }, /* disabled */
> + { 128 * MiB, 128 * MiB }, /* default is disabled but needed for -kernel */
> { 0x0, 0 }, /* disabled */
> };
>
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-08-07 0:14 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:20 [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 01/19] m25p80: Return the JEDEC ID twice for mx25l25635e Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f Cédric Le Goater
2020-08-06 22:55 ` Joel Stanley
2020-08-07 5:59 ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 03/19] m25p80: Add support for n25q512ax3 Cédric Le Goater
2020-08-06 22:56 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400 Cédric Le Goater
2020-08-06 13:32 ` Philippe Mathieu-Daudé
2020-08-06 13:49 ` Cédric Le Goater
2020-08-06 14:08 ` Philippe Mathieu-Daudé
2020-08-06 22:57 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 05/19] hw/arm/aspeed: Add board model for Supermicro X11 BMC Cédric Le Goater
2020-08-06 23:23 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 06/19] aspeed/smc: Fix MemoryRegionOps definition Cédric Le Goater
2020-08-06 23:24 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 07/19] aspeed/smc: Fix max_slaves of the legacy SMC device Cédric Le Goater
2020-08-06 23:24 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence Cédric Le Goater
2020-08-06 23:42 ` Joel Stanley
2020-08-07 6:04 ` Cédric Le Goater
2020-08-10 17:16 ` Cédric Le Goater
2020-08-10 23:20 ` Joel Stanley
2020-08-11 7:05 ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 09/19] ftgmac100: Fix registers that can be read Cédric Le Goater
2020-08-06 13:33 ` Philippe Mathieu-Daudé
2020-08-06 23:44 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 10/19] ftgmac100: Fix interrupt status "Packet transmitted on ethernet" Cédric Le Goater
2020-08-06 23:47 ` Joel Stanley
2020-08-07 6:06 ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 11/19] ftgmac100: Fix interrupt status "Packet moved to RX FIFO" Cédric Le Goater
2020-08-06 23:48 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 12/19] ftgmac100: Change interrupt status when a DMA error occurs Cédric Le Goater
2020-08-06 23:51 ` Joel Stanley
2020-08-07 6:19 ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 13/19] ftgmac100: Check for invalid len and address before doing a DMA transfer Cédric Le Goater
2020-08-06 23:51 ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx() Cédric Le Goater
2020-08-06 23:57 ` Joel Stanley
2020-08-10 13:43 ` Mauro Matteo Cascella
2020-08-10 17:14 ` Cédric Le Goater
2020-08-11 12:20 ` Mauro Matteo Cascella
2020-08-11 12:39 ` Peter Maydell
2020-08-18 14:54 ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 15/19] ftgmac100: Improve software reset Cédric Le Goater
2020-08-06 13:40 ` Philippe Mathieu-Daudé
2020-08-07 0:03 ` Joel Stanley
2020-08-07 6:21 ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 16/19] aspeed/sdmc: Perform memory training Cédric Le Goater
2020-08-06 13:38 ` Philippe Mathieu-Daudé
2020-08-07 0:10 ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 17/19] aspeed/sdmc: Allow writes to unprotected registers Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 18/19] aspeed/sdmc: Simplify calculation of RAM bits Cédric Le Goater
2020-08-07 0:11 ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 19/19] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller Cédric Le Goater
2020-08-07 0:12 ` Joel Stanley [this message]
2020-08-06 13:24 ` [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions Cédric Le Goater
2020-08-07 9:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xc4uGR5OAX=TNmjDdHD7i2mzEkhJVty8tn-Z=g6spBgGw@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).