From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9E4C433DF for ; Thu, 6 Aug 2020 23:53:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E5D0204EF for ; Thu, 6 Aug 2020 23:53:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="QB41AFds" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E5D0204EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3phL-00020k-Iz for qemu-devel@archiver.kernel.org; Thu, 06 Aug 2020 19:53:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3pcV-0007vY-30; Thu, 06 Aug 2020 19:48:23 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:46223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3pcT-0004eh-K8; Thu, 06 Aug 2020 19:48:22 -0400 Received: by mail-ed1-x542.google.com with SMTP id q4so33173799edv.13; Thu, 06 Aug 2020 16:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gC87vBsUsvMkWV5AOgd6HXISOv8B5xWjWIbBBoAT/5E=; b=QB41AFdsQUVAwcUYFqyiWg2UpLXbQ955MbVBOk2v4ziZ9g6sCWwVlYG1kzwRrRCFlZ +qWWNi8x8GOxJGOW7EpjhEZxVmTy6MXJqWrFOdWmJ1+12t5SU/ZGrdCWAS9ulosvuiow gEFnmUZ7mZ9mliKNl/ymqUbW+lLZ1Lg9EvKns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gC87vBsUsvMkWV5AOgd6HXISOv8B5xWjWIbBBoAT/5E=; b=cJAnSKtcQ2es9G9wcNS6aYuXRe3kJrxBRgHR+aPOt9uTwhjoVN9iKnTtAm5ybqYsV4 vFI9gUrE/fxJ7EROsqjCiaHJ6cFnjPmd5Wn9BTAQAe98Xz3SvL682B2JeIJfd4fJZUeS 8K6yWmTxlYNPX4ht6fKM2WCMETj/JfbF5sq2M0+J3vvZOYzmzi6OOJ2lqK6J0Udl66bF bZ4bxQ+gQ4DQr67Tnj9wo8ecIkugyIbaOVAmMg/VA1acQhI0i73822udS6fNmdW4A6DS qP48UGysqjJpnyDH3/I2YdLXMU5I6F4TJqkhzQ8MThGvcgBVFSEjh1M31OII/xjd/ykI mKJA== X-Gm-Message-State: AOAM53046/VD97wt6ntHj43LZmi3TyILyxviVwX7dCUobcEJRPk0AS3H U/kfg9jgKywxanJjBA5pvxb4CY5wcuqIz8O39mI= X-Google-Smtp-Source: ABdhPJxebV5fM2teDsyOBsxGnPs7MRZ3qFqMy5UtA2gpyI8grgV6wOr1hgPmXc7o4Rbr5zerPM/G5G5fF7z/IMRgEz8= X-Received: by 2002:aa7:dc02:: with SMTP id b2mr6266764edu.260.1596757699375; Thu, 06 Aug 2020 16:48:19 -0700 (PDT) MIME-Version: 1.0 References: <20200806132106.747414-1-clg@kaod.org> <20200806132106.747414-12-clg@kaod.org> In-Reply-To: <20200806132106.747414-12-clg@kaod.org> From: Joel Stanley Date: Thu, 6 Aug 2020 23:48:07 +0000 Message-ID: Subject: Re: [PATCH for-5.2 11/19] ftgmac100: Fix interrupt status "Packet moved to RX FIFO" To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::542; envelope-from=joel.stan@gmail.com; helo=mail-ed1-x542.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , qemu-arm , QEMU Developers , Frederic Konrad Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 6 Aug 2020 at 13:21, C=C3=A9dric Le Goater wrote: > > As we don't model the RX or TX FIFO, raise the "Packet moved to RX > FIFO" interrupt status bit as soon as we are handling a RX packet. > > Cc: Frederic Konrad > Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Joel Stanley > --- > hw/net/ftgmac100.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c > index aa3c05ef9882..5c0fe2d8cb75 100644 > --- a/hw/net/ftgmac100.c > +++ b/hw/net/ftgmac100.c > @@ -950,6 +950,7 @@ static ssize_t ftgmac100_receive(NetClientState *nc, = const uint8_t *buf, > break; > } > > + s->isr |=3D FTGMAC100_INT_RPKT_FIFO; > addr =3D s->rx_descriptor; > while (size > 0) { > if (!ftgmac100_can_receive(nc)) { > @@ -1001,8 +1002,6 @@ static ssize_t ftgmac100_receive(NetClientState *nc= , const uint8_t *buf, > /* Last buffer in frame. */ > bd.des0 |=3D flags | FTGMAC100_RXDES0_LRS; > s->isr |=3D FTGMAC100_INT_RPKT_BUF; > - } else { > - s->isr |=3D FTGMAC100_INT_RPKT_FIFO; > } > ftgmac100_write_bd(&bd, addr); > if (bd.des0 & s->rxdes0_edorr) { > -- > 2.25.4 >