From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CCABC433F5 for ; Tue, 8 Mar 2022 23:11:31 +0000 (UTC) Received: from localhost ([::1]:52406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRizK-0007Xp-7f for qemu-devel@archiver.kernel.org; Tue, 08 Mar 2022 18:11:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRivf-0005ml-8Q; Tue, 08 Mar 2022 18:07:43 -0500 Received: from [2607:f8b0:4864:20::f34] (port=46870 helo=mail-qv1-xf34.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRivd-0000k0-3M; Tue, 08 Mar 2022 18:07:42 -0500 Received: by mail-qv1-xf34.google.com with SMTP id j5so655648qvs.13; Tue, 08 Mar 2022 15:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=x57LrVMiCqoasIMX7qOPQGjVS39cCnI7YTtBC7jqjMw=; b=jTxy4wYdncvKt5UmA4pG9PUdxqeQwsrlgQERnDZjHUXWbHnAZfTDkEhkULzXGXxfuB A7t+s8bGVFjWZlXpWXriQ2mvPMPbb7HhgqIwk0W3ykJCMKzWSBl4IQGKJuc+EydSLHFD IACVNwsCGno+3RrJi7PM7TOGjkX7RpWyabvG8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=x57LrVMiCqoasIMX7qOPQGjVS39cCnI7YTtBC7jqjMw=; b=q2xaSQDnmB4EWX4Hl8dyH1Mun3bl/Hj/JVLHfcRNpE1WiAywyIFiIO3TPFaESsLpbL YQpf0clpH3Xf0SCbTYeaKGk/xgLAl5X0oZuBRlqe+cuG4HD+zkU2bsEOAZ8V1xUOJ+7U HGki3JD+Y9j4lQDWOpusqCRp03GgkaeBuj8EFTypHANmWw9Fij3DTodTU9ncct4ZznrQ JCP3lZkuy5eLBaa+S/m9Sjb9QzoP1b7SQmDTYkiFUd87xwQaWiJZkr/6sRNphBd0yBTX nxuzsFzU4uBxCylaf6TSkBS1ujNpzQm+XXOV+3eE9PqCswj2H925jja6ll+7dyE2dJML Qxug== X-Gm-Message-State: AOAM5326O23c8R6rygCviDW/YkWnfpoVxTCPxuMF41OnpoQ6LoNKBWoE jDUr1y012ZIGbaaYiLZZwIpnoPV+WnUyARAsebI= X-Google-Smtp-Source: ABdhPJylqmhxW22ThB+T9GB8ReMYru3MUE20T4zVie3dg+GaRgl3NHSGsMBlRa50CMI9HmRzgw6wzNfqyoH2BGhD9WA= X-Received: by 2002:a05:6214:c67:b0:435:bbb2:5c40 with SMTP id t7-20020a0562140c6700b00435bbb25c40mr1558358qvj.21.1646780856340; Tue, 08 Mar 2022 15:07:36 -0800 (PST) MIME-Version: 1.0 References: <20220305000656.1944589-1-patrick@stwcx.xyz> <20220305000656.1944589-2-patrick@stwcx.xyz> <790dd79a-4c5e-207e-86a9-9351694f0427@kaod.org> <2b9aed65-5cdf-0647-dc25-7cc9d488aaa6@kaod.org> In-Reply-To: From: Joel Stanley Date: Tue, 8 Mar 2022 23:07:23 +0000 Message-ID: Subject: Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type To: Patrick Williams Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f34 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f34; envelope-from=joel.stan@gmail.com; helo=mail-qv1-xf34.google.com X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , "open list:ASPEED BMCs" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , "open list:All patches CC here" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 8 Mar 2022 at 17:23, Patrick Williams wrote: > > On Tue, Mar 08, 2022 at 09:14:07AM +0100, C=C3=A9dric Le Goater wrote: > > > > >> There are two flash devices on the FMC. I can fix it inline since > > >> it is the only change I would request. > > > > > > Yes, there are. I think all of the Facebook systems have dual FMC, f= or > > > redundancy in hardware, but we can get by in QEMU with just a single = one. > > > > yes, the kernel will complain though and I don't know how robust > > the spi-nor based driver is. I think you sent a patch for a related > > issue. > > > > The newer spi-mem driver should be fine. > > Oh yes. I already forgot that I'm running with that patch since Joel add= ed it > to our backport 5.15 branch. One of the reasons I wrote that patch was t= o make > QEMU not kpanic. :( > > > > > > I'll see however you fix it up and see I can update all the other sys= tems as > > > well. > > > > ok. may be for 7.1 then. > > > > > We have an internal patch to expand the CS on FMC to 2 but we haven't > > > upstreamed it yet and I'm worried it will break some users w.r.t. the= CLI > > > changing for adding images. > > > > Yes. That's the problem. I am afraid some CI systems will break with > > these change in a newer QEMU. The command line options will need to > > adapt. > > My recollection is that the Romulus CI uses a branch of QEMU that at this= point > is rather old anyhow. We should be able to fix up the CI scripts at the = same > time we upgrade. It looks like that branch missed the 7.2 boat. Given it's imminent release, we should update the branch to Cedric's aspeed-7.0 when 7.0 is tagged. With this branch could do CI on Rainier (or S6Q, or transformers) with the eMMC image. I think there's value in doing CI on both eMMC and SPI machines. I'd like to see a boot test added for all of the machines in CI. Most (all?) machines will get to bmc standby by booting on a generic Qemu machine, such as the evb. The machines that do have more of the system modelled could boot that instead, and in the future add further tests. > > Are you or Andrew J maintaining that branch? > > > > My recollection is that the Romulus CI on OpenBMC relies on the PNOR > > > being the 2nd argument. > > > > That's the initial assumption made years ago. First mtd device is FMC, > > second is the PNOR. It is reaching its limits. > > > > I am looking at improving the command line argument to support: > > > > -drive file=3D,format=3Draw,id=3Ddrive0 -device mx66l1g45g,bus= =3Dssi.0,drive=3Ddrive0 > > > > which we would clearly define the topology. Adding a cs=3D[0-5] or and > > addr=3D[0-5] is the next step. > > Seems fine to me. > > -- > Patrick Williams