From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qk2aJ-0001fj-Lf for qemu-devel@nongnu.org; Thu, 21 Jul 2011 19:23:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qk2aI-0003Xu-3e for qemu-devel@nongnu.org; Thu, 21 Jul 2011 19:23:15 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:47686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qk2aI-0003Xq-0b for qemu-devel@nongnu.org; Thu, 21 Jul 2011 19:23:14 -0400 Received: by qyk30 with SMTP id 30so1108168qyk.4 for ; Thu, 21 Jul 2011 16:23:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1309620180-12652-1-git-send-email-hpoussin@reactos.org> References: <1309620180-12652-1-git-send-email-hpoussin@reactos.org> From: Artyom Tarasenko Date: Fri, 22 Jul 2011 01:22:52 +0200 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] esp: correctly fill bus id with requested lun List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Herv=E9_Poussineau?= Cc: qemu-devel@nongnu.org 2011/7/2 Herv=E9 Poussineau : > This bug showed up after 1455084ea2c48abf23c4e4e15e378ee43457f381, and > may be seen only on operating systems *not* using DMA to give commands > to SCSI adapter. > > Signed-off-by: Herv=E9 Poussineau > --- > =A0hw/esp.c | =A0 =A02 +- > =A01 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/esp.c b/hw/esp.c > index 6d3f5d2..8e95672 100644 > --- a/hw/esp.c > +++ b/hw/esp.c > @@ -211,7 +211,7 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf) > =A0 =A0 } else { > =A0 =A0 =A0 =A0 dmalen =3D s->ti_size; > =A0 =A0 =A0 =A0 memcpy(buf, s->ti_buf, dmalen); > - =A0 =A0 =A0 =A0buf[0] =3D 0; > + =A0 =A0 =A0 =A0buf[0] =3D buf[2] >> 5; why this byte needs to be overwritten? Doesn't ti_buf have a bus id? > =A0 =A0 } > =A0 =A0 DPRINTF("get_cmd: len %d target %d\n", dmalen, target); > > -- > 1.7.5.4 > > > --=20 Regards, Artyom Tarasenko solaris/sparc under qemu blog: http://tyom.blogspot.com/