From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqiar-0007Mc-Sf for qemu-devel@nongnu.org; Thu, 14 Apr 2016 10:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqiaq-0006we-HY for qemu-devel@nongnu.org; Thu, 14 Apr 2016 10:50:05 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:36704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqiaq-0006wE-40 for qemu-devel@nongnu.org; Thu, 14 Apr 2016 10:50:04 -0400 Received: by mail-lf0-x241.google.com with SMTP id 13so390244lfz.3 for ; Thu, 14 Apr 2016 07:50:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <570FA717.3000607@ilande.co.uk> References: <570F9E3A.4030809@ilande.co.uk> <570FA717.3000607@ilande.co.uk> From: Artyom Tarasenko Date: Thu, 14 Apr 2016 16:49:43 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/2 for-2.6] target-sparc: fix Nucleus quad LDD 128 bit access for windowed registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: qemu-devel On Thu, Apr 14, 2016 at 4:20 PM, Mark Cave-Ayland wrote: > On 14/04/16 15:04, Artyom Tarasenko wrote: > >> Can you please show the output of your checkpatch.pl report? I get: >> >> $ scripts/checkpatch.pl >> 0001-target-sparc-fix-Nucleus-quad-LDD-128-bit-access-for.patch >> total: 0 errors, 0 warnings, 25 lines checked >> 0001-target-sparc-fix-Nucleus-quad-LDD-128-bit-access-for.patch has no >> obvious style problems and is ready for Submission. > > Okay I've just done an update pull and complete rebuild which fixes the > fuzz, but I'm still seeing line ending errors in checkpatch.pl: > > > $ ./scripts/checkpatch.pl /tmp/artyom/\[PATCH\ 1_2\ for-2.6\]\ > target-sparc\:\ fix\ Nucleus\ quad\ LDD\ 128\ bit\ access\ for\ > windowed\ registers.eml > ERROR: DOS line endings > #75: FILE: target-sparc/ldst_helper.c:2062: > + env->regwptr[rd - 8] = cpu_ldq_nucleus(env, addr);^M$ > > ERROR: DOS line endings > #76: FILE: target-sparc/ldst_helper.c:2063: > + env->regwptr[rd + 1 - 8] = cpu_ldq_nucleus(env, addr + 8);^M$ > > ERROR: DOS line endings > #80: FILE: target-sparc/ldst_helper.c:2065: > + bswap64s(&env->regwptr[rd - 8]);^M$ > > ERROR: DOS line endings > #81: FILE: target-sparc/ldst_helper.c:2066: > + bswap64s(&env->regwptr[rd + 1 - 8]);^M$ > > ERROR: DOS line endings > #91: FILE: target-sparc/ldst_helper.c:2079: > + env->regwptr[rd - 8] = helper_ld_asi(env, addr, asi, 4, 0);^M$ > > ERROR: DOS line endings > #92: FILE: target-sparc/ldst_helper.c:2080: > + env->regwptr[rd + 1 - 8] = helper_ld_asi(env, addr + 4, > asi, 4, 0);^M$ > > total: 6 errors, 0 warnings, 25 lines checked > > /tmp/artyom/[PATCH 1_2 for-2.6] target-sparc: fix Nucleus quad LDD 128 > bit access for windowed registers.eml has style problems, please review. > If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > and: > > $ ./scripts/checkpatch.pl /tmp/artyom/\[PATCH\ 2_2\ for-2.6\]\ > target-sparc\:\ fix\ Trap\ Based\ Address\ Register\ behavior\ for\ > sparc64.eml > ERROR: DOS line endings > #85: FILE: target-sparc/int64_helper.c:161: > + env->pc = env->tbr & ~0x7fffULL;^M$ > > ERROR: DOS line endings > #86: FILE: target-sparc/int64_helper.c:162: > + env->pc |= ((env->tl > 1) ? 1 << 14 : 0) | (intno << 5);^M$ > > total: 2 errors, 0 warnings, 11 lines checked > > /tmp/artyom/[PATCH 2_2 for-2.6] target-sparc: fix Trap Based Address > Register behavior for sparc64.eml has style problems, please review. If > any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > > Possibly the DOS line endings are being added by a mail program? I use git send-email (which uses msmtp). Used to work fine. Clicking on "download mbox" on https://patchwork.ozlabs.org/patch/610402/ and running checkpatch.pl reveals no errors. Are you sure the problem is not on your side? Kind regards, Artyom -- Regards, Artyom Tarasenko SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu