From: Roman Penyaev <r.peniaev@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/1] chardev/char: fix qemu_chr_is_busy() check
Date: Thu, 10 Oct 2024 12:50:19 +0200 [thread overview]
Message-ID: <CACZ9PQV0n7nXYDcNZO2N0L56RMHQgoyAJfi-603DP+ftFK_nQg@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CL8VPo64DVty94FY4KyKr1h8_dbmrqLfy06VuMzoNyYYA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
On Thu, Oct 10, 2024, 12:20 Marc-André Lureau <marcandre.lureau@gmail.com>
wrote:
> Hi Roman
>
> On Thu, Oct 10, 2024 at 1:28 PM Roman Penyaev <r.peniaev@gmail.com> wrote:
>
>> `mux_cnt` struct member never goes negative or decrements,
>> so mux chardev can be !busy only when there are no
>> frontends attached. This patch fixes the always-true
>> check.
>>
>> Fixes: a4afa548fc6d ("char: move front end handlers in CharBackend")
>> Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
>> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
>> Cc: qemu-devel@nongnu.org
>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> That would be worth some new tests for chardev removal. It seems to be
> lacking. And mux probably need extra fixing. I can take a look if you don't.
>
I assume no one removes mux device, so no one observes the error. Please,
go ahead, I'm not sure I do fully understand what exactly should be fixed.
--
Roman
[-- Attachment #2: Type: text/html, Size: 2099 bytes --]
next prev parent reply other threads:[~2024-10-10 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 9:26 [PATCH 1/1] chardev/char: fix qemu_chr_is_busy() check Roman Penyaev
2024-10-10 10:19 ` Marc-André Lureau
2024-10-10 10:50 ` Roman Penyaev [this message]
2024-10-14 11:44 ` Roman Penyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ9PQV0n7nXYDcNZO2N0L56RMHQgoyAJfi-603DP+ftFK_nQg@mail.gmail.com \
--to=r.peniaev@gmail.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).