qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Roman Penyaev <r.peniaev@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 7/8] chardev/mux: implement detach of frontends from mux
Date: Mon, 14 Oct 2024 15:57:48 +0200	[thread overview]
Message-ID: <CACZ9PQWKv5oHnFVbRRqkN2MR5_t6yyAVb+=q15CWaWcvi2sOzA@mail.gmail.com> (raw)
In-Reply-To: <CAJ+F1CL6SNBFwo3CgfZR-WhahrcwGky3zTHzHUyoztDbUEroNQ@mail.gmail.com>

On Mon, Oct 14, 2024 at 3:22 PM Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:

[cut]

>>
>> +bool mux_chr_detach_frontend(MuxChardev *d, unsigned int tag)
>> +{
>> +    unsigned int bit;
>> +
>> +    bit = find_next_bit(&d->mux_bitset, MAX_MUX, tag);
>> +    if (bit >= MAX_MUX) {
>
>
> if (bit != tag) instead?

Right, thanks.

--
Roman


  reply	other threads:[~2024-10-14 14:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 11:41 [PATCH 0/8] chardev/mux: implement frontend detach Roman Penyaev
2024-10-14 11:41 ` [PATCH 1/8] chardev/char: fix qemu_chr_is_busy() check Roman Penyaev
2024-10-14 11:41 ` [PATCH 2/8] chardev/chardev-internal: remove unused `max_size` struct member Roman Penyaev
2024-10-14 11:41 ` [PATCH 3/8] chardev/mux: use bool type for `linestart` and `term_got_escape` Roman Penyaev
2024-10-14 11:41 ` [PATCH 4/8] chardev/mux: convert size members to unsigned int Roman Penyaev
2024-10-14 11:41 ` [PATCH 5/8] chardev/mux: introduce `mux_chr_attach_frontend() call Roman Penyaev
2024-10-14 11:41 ` [PATCH 6/8] chardev/mux: switch mux frontends management to bitset Roman Penyaev
2024-10-14 13:20   ` Marc-André Lureau
2024-10-14 13:56     ` Roman Penyaev
2024-10-14 14:02       ` Marc-André Lureau
2024-10-14 11:41 ` [PATCH 7/8] chardev/mux: implement detach of frontends from mux Roman Penyaev
2024-10-14 13:22   ` Marc-André Lureau
2024-10-14 13:57     ` Roman Penyaev [this message]
2024-10-14 11:41 ` [PATCH 8/8] tests/unit/test-char: implement a few mux remove test cases Roman Penyaev
2024-10-14 13:22 ` [PATCH 0/8] chardev/mux: implement frontend detach Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACZ9PQWKv5oHnFVbRRqkN2MR5_t6yyAVb+=q15CWaWcvi2sOzA@mail.gmail.com' \
    --to=r.peniaev@gmail.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).