From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCF2C48BDF for ; Thu, 24 Jun 2021 12:30:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F69A6054E for ; Thu, 24 Jun 2021 12:30:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F69A6054E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwOVW-0006CW-0Y for qemu-devel@archiver.kernel.org; Thu, 24 Jun 2021 08:30:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwOUM-0005ES-H9 for qemu-devel@nongnu.org; Thu, 24 Jun 2021 08:29:46 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:39846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwOUK-0004qT-SR for qemu-devel@nongnu.org; Thu, 24 Jun 2021 08:29:46 -0400 Received: by mail-oi1-x231.google.com with SMTP id b2so4729941oiy.6 for ; Thu, 24 Jun 2021 05:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IjOonRnWKWmh+G2v8nTcE09HEh1ot/gugSTNxqghVTM=; b=k72lZlsy+pljAplVXox8OBPHBZnOEigdcXGVPZN/eifsAlN+mxheyYnbQ0AUyRPzQv O2qGPAwjYn3/otmCdRf8vbrLqLHtgPZcdVvJwetoyNeHfkavxX62WzAqU9i7cRMQgajx dIW7CEgZYM1cAa6GlAzixPR2yeH9yunQUwW3yHTzBOFx9mCtEPwdk+0tnmwerZFSPgVd YuoIzfk64vpXjNJ+1mFnPNsOL2ozY6K9wioju/1EhL4U/tCuAntk2dfhrYVrO62qvllt zsgpABRT7+ap1mP5SGgygm4ZFrBw5m5TepZWW98PQVXKu6+YF5KU3n9ylsgZ/69VStKW z5Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IjOonRnWKWmh+G2v8nTcE09HEh1ot/gugSTNxqghVTM=; b=KYbS+eE7iAw0UIqjEFAn8dPoOo7bUiL+Y82ldsuL2szmdmzGCCPHbFbpGkSJZEnvCn chjPip+i0bympUwNnHRIyy5smx5hUe7dX96Jt14UENYKq5ldVVxwuBSWyf0H5nI5GmDv x+bLxYW/idE/Mk17G843XP9nTljP7cofW5i6Wqquz857/W6Wq2ajxgybRI+eYZ2GtFkH gvNoCeID5CKRSiz0x0sMMO34WCp8wUKoxbzMX7H6WdhS0A/pY4Tbo5UHiDM9M+TbxyH8 2jxAEkDu2QT2k3klXeGI5ASuBLIRJUwA3hXyL9NZFOUSVIljEDBo6IKk6rItuN8D3QMc 162Q== X-Gm-Message-State: AOAM533MECBWr+2laFciAuWsa4fgsn2YpFIEQcOBAs2n7vHjdOrK79Gb 7P/omSY0wzORE7D6nPvBl/llJp52ef3uMgwBACI= X-Google-Smtp-Source: ABdhPJx0NDeS0MFlB1hXkZ4AFZYlX0jQ9dV/Wlol1jsL4Zjjb4OOSowMMP8SsMA7A6H4K9TAFYv/Bh65ydCH/9nfSOI= X-Received: by 2002:a54:4690:: with SMTP id k16mr6993929oic.57.1624537783769; Thu, 24 Jun 2021 05:29:43 -0700 (PDT) MIME-Version: 1.0 References: <20210617190739.3673064-1-jusual@redhat.com> <20210623144747.285302-1-jusual@redhat.com> In-Reply-To: <20210623144747.285302-1-jusual@redhat.com> From: Marcel Apfelbaum Date: Thu, 24 Jun 2021 15:29:32 +0300 Message-ID: Subject: Re: [PATCH] hw/pci/pcie_port: Rename "enable-native-hotplug" property To: Julia Suvorova Content-Type: multipart/alternative; boundary="000000000000869e7605c5822d53" Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=marcel.apfelbaum@gmail.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu devel list , Eduardo Habkost , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000869e7605c5822d53 Content-Type: text/plain; charset="UTF-8" On Wed, Jun 23, 2021 at 5:47 PM Julia Suvorova wrote: > PCIE_SLOT property renamed to "native-hotplug" to be more concise > and consistent with other properties. > > Signed-off-by: Julia Suvorova > --- > hw/i386/pc_q35.c | 4 ++-- > hw/pci/pcie_port.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index a0ec7964cc..04b4a4788d 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -243,8 +243,8 @@ static void pc_q35_init(MachineState *machine) > NULL); > > if (acpi_pcihp) { > - object_register_sugar_prop(TYPE_PCIE_SLOT, > "enable-native-hotplug", > - "false", true); > + object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug", > + "false", true); > } > > /* irq lines */ > diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c > index a410111825..da850e8dde 100644 > --- a/hw/pci/pcie_port.c > +++ b/hw/pci/pcie_port.c > @@ -148,7 +148,7 @@ static Property pcie_slot_props[] = { > DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0), > DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0), > DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true), > - DEFINE_PROP_BOOL("enable-native-hotplug", PCIESlot, native_hotplug, > true), > + DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true), > DEFINE_PROP_END_OF_LIST() > }; > > -- > 2.30.2 > > Reviewed-by: Marcel Apfelbaum Thanks, Marcel --000000000000869e7605c5822d53 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jun 23, 2021 at 5:47 PM Julia= Suvorova <jusual@redhat.com>= ; wrote:
PCIE_SL= OT property renamed to "native-hotplug" to be more concise
and consistent with other properties.

Signed-off-by: Julia Suvorova <jusual@redhat.com>
---
=C2=A0hw/i386/pc_q35.c=C2=A0 =C2=A0| 4 ++--
=C2=A0hw/pci/pcie_port.c | 2 +-
=C2=A02 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index a0ec7964cc..04b4a4788d 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -243,8 +243,8 @@ static void pc_q35_init(MachineState *machine)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0NULL);

=C2=A0 =C2=A0 =C2=A0if (acpi_pcihp) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 object_register_sugar_prop(TYPE_PCIE_SLOT, &qu= ot;enable-native-hotplug",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "false", true);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 object_register_sugar_prop(TYPE_PCIE_SLOT, &qu= ot;native-hotplug",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"false", true= );
=C2=A0 =C2=A0 =C2=A0}

=C2=A0 =C2=A0 =C2=A0/* irq lines */
diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
index a410111825..da850e8dde 100644
--- a/hw/pci/pcie_port.c
+++ b/hw/pci/pcie_port.c
@@ -148,7 +148,7 @@ static Property pcie_slot_props[] =3D {
=C2=A0 =C2=A0 =C2=A0DEFINE_PROP_UINT8("chassis", PCIESlot, chassi= s, 0),
=C2=A0 =C2=A0 =C2=A0DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0)= ,
=C2=A0 =C2=A0 =C2=A0DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug= , true),
-=C2=A0 =C2=A0 DEFINE_PROP_BOOL("enable-native-hotplug", PCIESlot= , native_hotplug, true),
+=C2=A0 =C2=A0 DEFINE_PROP_BOOL("native-hotplug", PCIESlot, nativ= e_hotplug, true),
=C2=A0 =C2=A0 =C2=A0DEFINE_PROP_END_OF_LIST()
=C2=A0};

--
2.30.2


Reviewed-by: Marcel Apfelbaum <marcel.apfelbau= m@gmail.com>

Thanks,
Marcel= =C2=A0
--000000000000869e7605c5822d53--